reficio#226 - add feedback of review

sparsick · Feb 25, 2021 · 167ffb3 · 167ffb3
1 parent 2560d80
commit 167ffb3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/main/java/org/reficio/p2/FeatureBuilder.java b/src/main/java/org/reficio/p2/FeatureBuilder.java
@@ -26,6 +26,7 @@
 import javax.xml.parsers.DocumentBuilderFactory;
 import javax.xml.parsers.ParserConfigurationException;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.reficio.p2.bundler.ArtifactBundlerInstructions;
 import org.reficio.p2.bundler.P2ArtifactMap;
 import org.reficio.p2.logger.Logger;
@@ -56,7 +57,7 @@ public FeatureBuilder(P2FeatureDefinition p2FeatureDefintion,
 	//cache this so that the same timestamp is used
 	private String featureTimeStamp;
 
-	@edu.umd.cs.findbugs.annotations.SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
+	@SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
 	public void generate(File destinationFolder) {
 		try {
 			File featureContent = new File(destinationFolder, this.getFeatureFullName());

diff --git a/src/main/java/org/reficio/p2/P2Mojo.java b/src/main/java/org/reficio/p2/P2Mojo.java
@@ -84,7 +84,7 @@
         requiresDependencyResolution = ResolutionScope.RUNTIME,
         requiresDependencyCollection = ResolutionScope.RUNTIME
 )
-@edu.umd.cs.findbugs.annotations.SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
+@SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
 public class P2Mojo extends AbstractMojo implements Contextualizable {
 
     private static final String BUNDLES_TOP_FOLDER = "/source";

diff --git a/src/main/java/org/reficio/p2/utils/JarUtils.java b/src/main/java/org/reficio/p2/utils/JarUtils.java
@@ -23,6 +23,7 @@
 import aQute.bnd.osgi.FileResource;
 import aQute.bnd.osgi.Jar;
 import aQute.bnd.osgi.Resource;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.io.IOUtils;
 import org.apache.maven.plugin.logging.Log;
@@ -78,7 +79,7 @@ public static void adjustSnapshotOutputVersion(File inputFile, File outputFile,
      * @param timestamp - timestamp
      *
      */
-    @edu.umd.cs.findbugs.annotations.SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
+    @SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
     public static void adjustFeatureXml(File inputFile, File outputFile, File pluginDir, Log log, String timestamp) {
         Jar jar = null;
         File newXml = null;