reficio#226 - add feedback of review

sparsick · Feb 25, 2021 · 2560d80 · 2560d80
1 parent 862879f
commit 2560d80
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 9 deletions.
diff --git a/src/main/groovy/org/reficio/p2/resolver/eclipse/impl/DefaultEclipseResolver.groovy b/src/main/groovy/org/reficio/p2/resolver/eclipse/impl/DefaultEclipseResolver.groovy
@@ -18,7 +18,7 @@
  */
 package org.reficio.p2.resolver.eclipse.impl
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings
 
 import org.reficio.p2.logger.Logger
 import org.reficio.p2.resolver.eclipse.EclipseResolutionRequest

diff --git a/src/main/groovy/org/reficio/p2/resolver/eclipse/impl/FileBinaryCategory.groovy b/src/main/groovy/org/reficio/p2/resolver/eclipse/impl/FileBinaryCategory.groovy
@@ -20,7 +20,7 @@ package org.reficio.p2.resolver.eclipse.impl
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
-@edu.umd.cs.findbugs.annotations.SuppressFBWarnings("SE_NO_SERIALVERSIONID")
+@SuppressFBWarnings("SE_NO_SERIALVERSIONID")
 class FileBinaryCategory {
     def static leftShift(File file, URL url) {
         url.withInputStream { is ->

diff --git a/src/main/groovy/org/reficio/p2/resolver/maven/impl/AetherResolver.groovy b/src/main/groovy/org/reficio/p2/resolver/maven/impl/AetherResolver.groovy
@@ -18,7 +18,7 @@
  */
 package org.reficio.p2.resolver.maven.impl
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings
 
 import org.reficio.p2.logger.Logger
 import org.reficio.p2.resolver.maven.impl.facade.AetherFacade
@@ -34,7 +34,7 @@ import org.reficio.p2.resolver.maven.ResolvedArtifact
  *         http://www.reficio.org
  * @since 1.0.0
  */
-@edu.umd.cs.findbugs.annotations.SuppressFBWarnings("SE_NO_SERIALVERSIONID")
+@SuppressFBWarnings("SE_NO_SERIALVERSIONID")
 class AetherResolver implements ArtifactResolver {
 
     static final String DEFAULT_SCOPE = "compile"

diff --git a/src/main/groovy/org/reficio/p2/resolver/maven/impl/facade/AetherEclipseFacade.groovy b/src/main/groovy/org/reficio/p2/resolver/maven/impl/facade/AetherEclipseFacade.groovy
@@ -18,7 +18,7 @@
  */
 package org.reficio.p2.resolver.maven.impl.facade
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings
 
 import org.eclipse.aether.artifact.Artifact as AetherArtifact
 import org.eclipse.aether.artifact.DefaultArtifact
@@ -39,7 +39,7 @@ import org.reficio.p2.resolver.maven.Artifact
  *         http://www.reficio.org
  * @since 1.1.0
  */
-@edu.umd.cs.findbugs.annotations.SuppressFBWarnings("SE_NO_SERIALVERSIONID")
+@SuppressFBWarnings("SE_NO_SERIALVERSIONID")
 class AetherEclipseFacade implements AetherFacade {
 
     @Override

diff --git a/src/main/groovy/org/reficio/p2/resolver/maven/impl/facade/AetherFacade.groovy b/src/main/groovy/org/reficio/p2/resolver/maven/impl/facade/AetherFacade.groovy
@@ -18,7 +18,6 @@
  */
 package org.reficio.p2.resolver.maven.impl.facade
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import org.reficio.p2.resolver.maven.Artifact
 

diff --git a/src/main/groovy/org/reficio/p2/resolver/maven/impl/facade/AetherSonatypeFacade.groovy b/src/main/groovy/org/reficio/p2/resolver/maven/impl/facade/AetherSonatypeFacade.groovy
@@ -18,7 +18,7 @@
  */
 package org.reficio.p2.resolver.maven.impl.facade
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings
 
 import org.reficio.p2.resolver.maven.Artifact
 import org.sonatype.aether.artifact.Artifact as AetherArtifact
@@ -39,7 +39,7 @@ import org.sonatype.aether.util.graph.PreorderNodeListGenerator
  *         http://www.reficio.org
  * @since 1.1.0
  */
-@edu.umd.cs.findbugs.annotations.SuppressFBWarnings("SE_NO_SERIALVERSIONID")
+@SuppressFBWarnings("SE_NO_SERIALVERSIONID")
 class AetherSonatypeFacade implements AetherFacade {
 
     @Override
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,6 @@ @@
      */
     package org.reficio.p2.resolver.maven.impl.facade
-    import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
     import org.reficio.p2.resolver.maven.Artifact
@@ Expand Down @@