Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Fitting Cleanup #485

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Conversation

duytnguyendtn
Copy link
Collaborator

With the introduction of #456, we now have a good foundation for some cleanup of the model fitting plugin. This PR implements the following changes:

  1. The model can be automatically added to the spectral viewers immediately without fear of this looping bug that's been plaguing us
  2. The "Apply to Cube" option only applies to the "Cubeviz" configuration, and therefore is only visible in Cubeviz
  3. With the introduction of Implement extraction of model fitting parameters #458, we can now extract models via code. This, combined with MAST's request that we don't allow saving to local resources in anticipation of Cloud Hosting, means the "Save to Disk" button is removed

I reviewed the docs, and these changes aren't actually mentioned in the docs, so there's nothing to change as far as I can see

@duytnguyendtn duytnguyendtn marked this pull request as draft March 18, 2021 20:39
@duytnguyendtn duytnguyendtn marked this pull request as ready for review March 18, 2021 20:41
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Contributor

@camipacifici camipacifici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants