Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A better fix for the GUI update loop #185 #456

Merged
merged 2 commits into from
Mar 8, 2021
Merged

A better fix for the GUI update loop #185 #456

merged 2 commits into from
Mar 8, 2021

Conversation

mariobuikhuizen
Copy link
Collaborator

A better fix for #185.

Reverts 95f3e8e and replaces v-treeview with a list of checkboxes.

@mariobuikhuizen
Revert "fix: prevent update loop when (de)selecting data checkboxes q…
b13d56e 
…uickly"

These lines is are necessary when changing the selection from the
back-end.
This reverts commit 95f3e8e.
@mariobuikhuizen mariobuikhuizen force-pushed the replace_treeview_with_list_of_checkboxes branch from b953d9c to 6b9d20f Compare March 2, 2021 17:28
@mariobuikhuizen mariobuikhuizen changed the title A better fix for #185 A better fix for the GUI update loop #185 Mar 2, 2021
javerbukh
javerbukh approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used this on cubeviz, mosviz, and specviz and it works great! Clicked repeatedly on checkboxes trying to trigger the bug and even though it occasionally takes a little bit to catch up, the application does not get stuck in a loop.

@rosteen rosteen requested review from rosteen and duytnguyendtn March 5, 2021 14:36
rosteen
rosteen requested changes Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested one very minor UI change, other than that this looks great. Tested programmatically changing selected data and it works, neither of the previous bugs occur.

jdaviz/container.vue Outdated Show resolved Hide resolved
@mariobuikhuizen mariobuikhuizen force-pushed the replace_treeview_with_list_of_checkboxes branch from 6b9d20f to a0875d8 Compare March 8, 2021 12:35
@rosteen
Copy link
Collaborator

rosteen commented Mar 8, 2021

Merging, thanks Mario!

@rosteen rosteen merged commit 625acca into spacetelescope:main Mar 8, 2021
@duytnguyendtn duytnguyendtn mentioned this pull request Mar 18, 2021
Merged
@maartenbreddels maartenbreddels mentioned this pull request Mar 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javerbukh javerbukh javerbukh approved these changes

@rosteen rosteen rosteen approved these changes

@duytnguyendtn duytnguyendtn Awaiting requested review from duytnguyendtn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariobuikhuizen @rosteen @javerbukh