Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TryGetRandomRecord in StationRecordsSystem #35452

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Feb 24, 2025

About the PR

Added a function for getting a random station record from a given station.
Taken from #35429 for atomization purposes.

Why / Balance

Technical details

Using IRobustRandom to find a random record in the StationRecordsComponent then returning it.

Media

Requirements

Breaking changes

Changelog

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. labels Feb 24, 2025
@ScarKy0 ScarKy0 requested a review from Tayrtahn February 24, 2025 17:20
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Feb 24, 2025
Copy link
Member

@Tayrtahn Tayrtahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Feb 24, 2025

Three approvals, self merging this :godo:

@ScarKy0 ScarKy0 merged commit 51104a7 into space-wizards:master Feb 24, 2025
13 checks passed
@ScarKy0 ScarKy0 deleted the get-random-record branch February 24, 2025 18:05
@Winkarst-cpu
Copy link
Contributor

Three approvals, self merging this :godo:

Eery evil creature, no good 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants