HOTFIX: fix minibomb implant and syndicats not exploding #34923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errant-4
approved these changes
Feb 6, 2025
|
We should fix the template to conform with the guidelines :) |
|
shouldnt be datafield since its a container which gets serialized in container container |
MilonPL
approved these changes
Feb 6, 2025
I don't disagree, I have been making noise about that at some point |
FluffMe
pushed a commit
to ss14-harmony/ss14-harmony
that referenced
this pull request
Feb 8, 2025
…ds#34923) fix minibomb implant not exploding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
See title.
Technical details
#33493 was a bugfix that intended to drop storage implant contents when being gibbed instead of deleting them. It did so by deleting all implants, which caused the implanter to drop its storage. However, this also caused the microbomb implant to be deleted before exploding because it first gibs the user.
We solve this by only emptying the storage implant on gibbing.
It is still deleted when the user's body is deleted.
Also added readonly VV access to the ImplantedComponent because that annoyed me every time I had to debug implants.
(probably should be a DataField, but that is out of scope)
Media
microbomb.fix.mp4
Requirements
Breaking changes
none
Changelog
🆑