-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engineering guidebook improvements #34695
Engineering guidebook improvements #34695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get reviewed, nerd
Just some minor nitpicks
Resources/ServerInfo/Guidebook/Engineering/PortableScrubber.xml
Outdated
Show resolved
Hide resolved
Resources/ServerInfo/Guidebook/Engineering/SingularityEngine.xml
Outdated
Show resolved
Hide resolved
I pushed the fixes that I found since you asked on discord, if you want to revert the optional ones feel free to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookings all fine to me now.
Hey! Very nice rewrite. I should've checked it out earlier for the following two nitpicks that I hope are still appropriate to post here: This looks like the same sentence twice? Section on the tesla: And since #34337 there's the Authentication Disruptor now. Might be good to mention it. The Airlocks no longer need to be partially deconstructed if using the access configurator. You get get them out of the annoying AA emag state with just the configurator (THANK GOD) |
Thanks for the catch, I'll write those up later. I often write twice during incoherent rambling (the entire guidebook) so thanks for catching it. |
I've updated parts of the Tesla Engine page to be more clear, added some solar panel info that I felt was needed, as well as outlined the recent changes to the Auth Disruptor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in game everything seems to work!
About the PR
Improved the engineering guidebook following review in #33062.
Adds a section for upgrading solar panels in the solar panel entry.
Why / Balance
Things need to have more clarity, new info (hey I said I would be keeping up with this godo).
Technical details
Adjusted YAML formatting
Media
Requirements
Changelog
🆑