Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engineering guidebook improvements #34695

Conversation

ArtisticRoomba
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba commented Jan 28, 2025

About the PR

Improved the engineering guidebook following review in #33062.

Adds a section for upgrading solar panels in the solar panel entry.

Why / Balance

Things need to have more clarity, new info (hey I said I would be keeping up with this godo).

Technical details

Adjusted YAML formatting

Media

image

Requirements

Changelog
🆑

  • add: The Solar Panels section of the Engineering Guidebook has been updated to include information on upgrading solar panels, as well as how much each variant produces.
  • tweak: The Tesla Engine section of the Engineering Guidebook has been slightly reorganized to better outline the differences between Grounding Rods and Tesla Coils, as well as tips on how to use them.
  • add: The Access Configurator section of the Engineering Guidebook has been updated to reflect the recent addition of the Authentication Disruptor, as well as how to fix access-broken doors and equipment the easy way.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. labels Jan 28, 2025
@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Engineering Area: Engineering department, including Atmospherics. A: Guidebook Area: Ingame guidebook, content or technical implementation and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 28, 2025
Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get reviewed, nerd
Just some minor nitpicks

@ScarKy0
Copy link
Contributor

ScarKy0 commented Jan 28, 2025

I pushed the fixes that I found since you asked on discord, if you want to revert the optional ones feel free to.

Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookings all fine to me now.

@ScarKy0 ScarKy0 added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Jan 28, 2025
@ScarKy0 ScarKy0 self-assigned this Jan 28, 2025
@CroilBird
Copy link
Contributor

CroilBird commented Feb 6, 2025

Hey! Very nice rewrite. I should've checked it out earlier for the following two nitpicks that I hope are still appropriate to post here:

This looks like the same sentence twice? Section on the tesla:

Screenshot_20250206_095302

And since #34337 there's the Authentication Disruptor now. Might be good to mention it.

image

The Airlocks no longer need to be partially deconstructed if using the access configurator. You get get them out of the annoying AA emag state with just the configurator (THANK GOD)

@ArtisticRoomba
Copy link
Contributor Author

Thanks for the catch, I'll write those up later.

I often write twice during incoherent rambling (the entire guidebook) so thanks for catching it.

@ArtisticRoomba
Copy link
Contributor Author

I've updated parts of the Tesla Engine page to be more clear, added some solar panel info that I felt was needed, as well as outlined the recent changes to the Auth Disruptor.

Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in game everything seems to work!

@beck-thompson beck-thompson merged commit ef4f5cf into space-wizards:master Feb 15, 2025
12 checks passed
@ArtisticRoomba ArtisticRoomba deleted the engineering-guidebook-improvements branch February 15, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Engineering Area: Engineering department, including Atmospherics. A: Guidebook Area: Ingame guidebook, content or technical implementation DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants