-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rehydratable mop bucket cube, refactor the rehydratable yml #34586
Open
Hrosts
wants to merge
12
commits into
space-wizards:master
Choose a base branch
from
Hrosts:rehydratable-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: No C#
Changes: Requires no C# knowledge to review or fix this item.
Changes: Sprites
Changes: Might require knowledge of spriting or visual design.
S: Untriaged
Status: Indicates an item has not been triaged and doesn't have appropriate labels.
size/M
Denotes a PR that changes 100-999 lines.
labels
Jan 22, 2025
ArtisticRoomba
added
P3: Standard
Priority: Default priority for repository items.
T: New Feature
Type: New feature or content, or extending existing content
T: Refactor
Type: Refactor of notable amount of codebase
D3: Low
Difficulty: Some codebase knowledge required.
S: Needs Review
Status: Requires additional reviews before being fully accepted
A: Service
Area: Service department, including cooking, botany, etc
A: Core Tech
Area: Underlying core tech for the game and the Github repository.
and removed
S: Untriaged
Status: Indicates an item has not been triaged and doesn't have appropriate labels.
labels
Jan 22, 2025
this is incredable |
Mop bucket cube.. sounds absurd.. ☠️ |
Simply brilliant. |
slarticodefast
requested changes
Jan 23, 2025
Resources/Prototypes/Entities/Objects/Specific/rehydrateable.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/rehydrateable.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/rehydrateable.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/rehydrateable.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/rehydrateable.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/rehydrateable.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Specific/rehydrateable.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Structures/Specific/Janitor/janicart.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Structures/Specific/Janitor/janicart.yml
Outdated
Show resolved
Hide resolved
Would like to have the dehydrated carp to contain carpotoxin, as their flesh contains it. |
It's pointless right now. You can't eat them, you can't grind them |
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A: Core Tech
Area: Underlying core tech for the game and the Github repository.
A: Service
Area: Service department, including cooking, botany, etc
Changes: No C#
Changes: Requires no C# knowledge to review or fix this item.
Changes: Sprites
Changes: Might require knowledge of spriting or visual design.
D3: Low
Difficulty: Some codebase knowledge required.
P3: Standard
Priority: Default priority for repository items.
S: Needs Review
Status: Requires additional reviews before being fully accepted
size/M
Denotes a PR that changes 100-999 lines.
T: New Feature
Type: New feature or content, or extending existing content
T: Refactor
Type: Refactor of notable amount of codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
UPD: Also refactored part of the monkey cube yml, now only actual monkey cubes and syndicate sponges (fake monkey cubes) can be used for the monkey cube bounty.
Why / Balance
I made a joke under #33613, then decided to actually do it. Then saw that the whole file could use a refactor.
Technical details
The basic components for rehydratable behavior (solution, Reactive, Rehydratable, collision) are described under RehydratableItem.
RehydratableAnimalCube inherits RehydratableItem and adds the cube sprite, as well as "meaty" solutions, food-related components and tags.
Most animal cubes directly inherit RehydratableAnimalCube. SyndicateSponge inherits from Monkey cube. MonkeyCube tag is present only on those 2, it used to be present on all animal cubes.
MopBucketCube inherits from RehydratableItem, and so is inedible.
Making DehydratedSpaceCarp edible is not straightforward, because
handle: false
needed for petting behavior also causes you to chew on the carp at the same time. I'm not knowledgeable enough to fix that, so I chose to just make the carp completely inedible.DehydratedSpaceCarp still has some questionable components, inherited from the plushie, primarily the secret stash.
Media
The Eat verb bug:
Requirements
Changelog
🆑