Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rehydratable mop bucket cube, refactor the rehydratable yml #34586

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Hrosts
Copy link
Contributor

@Hrosts Hrosts commented Jan 22, 2025

About the PR

  • Refactored the yml for all rehydratable items (mob cubes and the dehydrated carp)
  • Changed all animal cubes to have same reagents as raw meat (used to be 10 nutriment)
  • Fixed the bug where moth players would see an unusable Eat verb on dehydrated space carps. Dehydrated carps now show no verb and contain no reagents.
  • Added a mop bucket cube, replacing the bucket itself in the janitorial supplies crate

UPD: Also refactored part of the monkey cube yml, now only actual monkey cubes and syndicate sponges (fake monkey cubes) can be used for the monkey cube bounty.

Why / Balance

I made a joke under #33613, then decided to actually do it. Then saw that the whole file could use a refactor.

Technical details

The basic components for rehydratable behavior (solution, Reactive, Rehydratable, collision) are described under RehydratableItem.
RehydratableAnimalCube inherits RehydratableItem and adds the cube sprite, as well as "meaty" solutions, food-related components and tags.
Most animal cubes directly inherit RehydratableAnimalCube. SyndicateSponge inherits from Monkey cube. MonkeyCube tag is present only on those 2, it used to be present on all animal cubes.
MopBucketCube inherits from RehydratableItem, and so is inedible.
Making DehydratedSpaceCarp edible is not straightforward, because handle: false needed for petting behavior also causes you to chew on the carp at the same time. I'm not knowledgeable enough to fix that, so I chose to just make the carp completely inedible.
DehydratedSpaceCarp still has some questionable components, inherited from the plushie, primarily the secret stash.

Media

image

The Eat verb bug:
Screenshot from 2025-01-22 04-03-03

Requirements

Changelog

🆑

  • add: Added rehydratable mop bucket cube, replacing the big and unwieldy yellow bucket in the janitorial supplies crate.

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Jan 22, 2025
Copy link
Contributor

github-actions bot commented Jan 22, 2025

RSI Diff Bot; head commit 836a2e8 merging into 3499b47
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Janitorial/janitorial.rsi

State Old New Status
mopbucket_cube Added

Edit: diff updated after 836a2e8

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content T: Refactor Type: Refactor of notable amount of codebase D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Service Area: Service department, including cooking, botany, etc A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 22, 2025
@Callmore
Copy link
Contributor

this is incredable

@NotSoDana
Copy link
Contributor

Mop bucket cube.. sounds absurd.. ☠️

@Errant-4
Copy link
Member

Simply brilliant.

@Luxzhv
Copy link

Luxzhv commented Jan 23, 2025

Would like to have the dehydrated carp to contain carpotoxin, as their flesh contains it.

@Hrosts
Copy link
Contributor Author

Hrosts commented Jan 23, 2025

Would like to have the dehydrated carp to contain carpotoxin, as their flesh contains it.

It's pointless right now. You can't eat them, you can't grind them

Hrosts and others added 6 commits January 23, 2025 21:22
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
@Hrosts Hrosts requested a review from slarticodefast January 23, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. A: Service Area: Service department, including cooking, botany, etc Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content T: Refactor Type: Refactor of notable amount of codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants