Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Attachbodypart Console Command #34577

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Coolsurf6
Copy link
Contributor

About the PR

Fixed a console command that would state it was functioning as intended but never actually attached a selected limb to an entity.

Massive thanks for Milon for helping out with this code!

Why / Balance

Want to mess with attaching body parts and would be good to have a command working.

Technical details

First portion of the implementation to connect a limb checked if the root container wasn't null, which in the right circumstance should be the case. This meant that the code to simply check was always running, and never the code to actually connect the limp.

Media

N/A

Requirements

Breaking changes

N/A

Changelog
🆑

  • fix: Attachbodypart command now functions as intended.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 22, 2025
@Coolsurf6
Copy link
Contributor Author

I may need some help with a better output for the WriteError command, but that's about it.

@ArtisticRoomba ArtisticRoomba added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants