Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a Genderqueer Pin! #34546

Closed
wants to merge 4 commits into from
Closed

Adding a Genderqueer Pin! #34546

wants to merge 4 commits into from

Conversation

centcomofficer24
Copy link
Contributor

About the PR

I have added a genderqueer pin.

Why / Balance

Beacuse there wasn't a genderqueer pin, so I made one.

Technical details

Just added the necessary code to add in a new pin.

Media

gay-equipped-NECK
gender

Requirements

Changelog

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

RSI Diff Bot; head commit 9fc1c9f merging into 6361a12
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Neck/Misc/pins.rsi

State Old New Status
gender-equipped-NECK Added
gender Added

Edit: diff updated after 9fc1c9f

ArtisticRoomba
ArtisticRoomba suggested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bunch of yml/json formatting errors

Resources/Textures/Clothing/Neck/Misc/pins.rsi/meta.json
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing gender state in the JSON for the gender pin icon

PJB3005
PJB3005 requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test your changes locally before sending a pull request like this.

@centcomofficer24
Copy link
Contributor Author

appolagies, will fix now.

centcomofficer24 and others added 3 commits January 20, 2025 21:17
@centcomofficer24 @ArtisticRoomba
Update Resources/Textures/Clothing/Neck/Misc/pins.rsi/meta.json
19c882c 
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
@centcomofficer24 @ArtisticRoomba
Update Resources/Prototypes/Entities/Clothing/Neck/pins.yml
afd89bb 
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
@centcomofficer24 @ArtisticRoomba
Update Resources/Textures/Clothing/Neck/Misc/pins.rsi/meta.json
9fc1c9f 
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
@centcomofficer24
Copy link
Contributor Author

I'll fix this and make a new PR, sorry.

@centcomofficer24 centcomofficer24 deleted the testing branch January 21, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 PJB3005 requested changes

@ArtisticRoomba ArtisticRoomba ArtisticRoomba requested changes

Assignees
No one assigned
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@centcomofficer24 @PJB3005 @ArtisticRoomba