Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Admin Menu player jobs #34545

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[HOTFIX] Admin Menu player jobs #34545

merged 1 commit into from
Jan 20, 2025

Conversation

Errant-4
Copy link
Member

@Errant-4 Errant-4 commented Jan 20, 2025 •
edited
Loading

About the PR

Jobs are once again shown for all players in the Admin Menu

Technical details

Role Types requried a slight reorganisation of the GameTicker spawn sequence, which accidentally resulted in the PlayerInfo data being refreshed before the players had their job mind roles added. The order should not be changed back because it would cause SharedRoleSystem to log some errors every time a player spawns. Instead, there is now an additional playerinfo refresh after the jobs are added.

Media

before
image

after
image

Requirements

Changelog
🆑 Errant
ADMIN:

  • fix: The admin playerlist once again shows all player jobs on roundstart.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Branch: Stable Intended to be merged into Stable. size/XS Denotes a PR that changes 0-9 lines. labels Jan 20, 2025
@Errant-4 Errant-4 added A: Admin Tooling Area: Admin tooling and moderation. A: Core Tech Area: Underlying core tech for the game and the Github repository. T: Bugfix Type: Bugs and/or bugfixes P1: High Priority: Higher priority than other items, but isn't an emergency. D3: Low Difficulty: Some codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. A: Core Tech Area: Underlying core tech for the game and the Github repository. labels Jan 20, 2025
ScarKy0
ScarKy0 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@Errant-4 Errant-4 added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jan 20, 2025
@slarticodefast slarticodefast merged commit 671ab10 into space-wizards:stable Jan 20, 2025
15 checks passed
@Errant-4 Errant-4 deleted the adminjobfix branch January 20, 2025 22:30
@Errant-4 Errant-4 mentioned this pull request Jan 20, 2025
Merged
widgetbeck pushed a commit to widgetbeck/imp-station-14 that referenced this pull request Jan 29, 2025
@Errant-4 @widgetbeck
[HOTFIX] Admin Menu player jobs (space-wizards#34545)
593b0ee 
update job info on spawn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScarKy0 ScarKy0 ScarKy0 approved these changes

Assignees
No one assigned
Labels
A: Admin Tooling Area: Admin tooling and moderation. Branch: Stable Intended to be merged into Stable. D3: Low Difficulty: Some codebase knowledge required. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Errant-4 @ScarKy0 @slarticodefast