Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TEG thief steal targets #34544

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ArtisticRoomba
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba commented Jan 20, 2025

About the PR

Remove the TEG and its parts as steal targets for the Thief.

Why / Balance

Unfortunately, the TEG is the only source of power for some maps, making engineering unable to power the station for the rest of the round if stolen. AME + Solars was never intended (by design) to be a long-term power source, and it's silly to expect engineering to treat these sources as such for the rest of the round.

It basically leaves engineering with no options on some stations but to call evac early and end the round 20 minutes in, give or take. Sabotaging the entire stations power permanently as an objective isn't really fun, it just makes it really annoying and a waste of 20 minutes as you wanted to roleplay/play the game, but instead you have to sit through a power outage reminiscent of pre-power balance engineering days.

Technical details

Obliterates them from YML.

Requirements

Changelog
🆑

  • remove: The TEG and its components are no longer a Thief steal target.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/S Denotes a PR that changes 10-99 lines. labels Jan 20, 2025
@ArtisticRoomba
Copy link
Contributor Author

An alternative to this PR is to make the TEG purchasable like it was in SS13, which fulfills the intended idea of making things on the station able to be replaced and not so intrinsic to the round. Going to get more feedback on that idea and might switch approaches to that one if the consensus leans more towards it.

@K-Dynamic
Copy link
Contributor

I'd make it purchasable at high price so thieves have more reason to bribe cargo or pay to replace the TEG

@ArtisticRoomba
Copy link
Contributor Author

I'd make it purchasable at high price so thieves have more reason to bribe cargo or pay to replace the TEG

The only issue is that this wraps back to the big problem with making thief objectives purchasable at cargo, mainly that it gets metagamed. This got to the point where we had to remove figurines as an objective. (#32413)

I know it's different with the TEG, but something to consider nonetheless.

@VerinSenpai
Copy link
Contributor

I need purchasable tegs so I can tell cargo it got hit by a meteor (it didn't) and have two tegs at once.

@Aisu9
Copy link

Aisu9 commented Jan 21, 2025

isn't the TEG board printable on 13? i remember seeing borgs repurposing entire chunk of the station with 20+ TEG only to run the station and produce enough extra for the energy to cargo-funds machine

@loksill
Copy link

loksill commented Jan 21, 2025

I think this is a good idea, but you can just add the option to buy a TEG in cargo.

@IWearKhakis
Copy link

Would it be a bad idea to replace the TEG steal objective with something else of equivalant high-difficulty but isn't as disruptive like perhaps a SMES?

@ArtisticRoomba
Copy link
Contributor Author

Would it be a bad idea to replace the TEG steal objective with something else of equivalant high-difficulty but isn't as disruptive like perhaps a SMES?

Probably a better idea. It would be best if it was an Advanced SMES, as they're quite difficult for engineering to steal (on most maps) while also not being the end of engineering if one is gone.

@kosticia
Copy link
Contributor

I don't like it. TEG is the one of the most interesting objectives for thief. Yes this can be a bit grief... But isn't a target of every antagonist? We should treat the disease, not the symptoms. TEG is just so much easy to sabotage even player not an antagonist and we should fix it, instead of just deleting the target.

@Compilatron144
Copy link
Contributor

Personally I think changing the objective from the TEG to an advanced SMES is a pretty good tradeoff. They're usually replaceable and about the same difficulty as a TEG, but won't cripple a station immediately.

@deltanedas
Copy link
Contributor

advanced smes will just be ask sci for funny board similar to beg cargo for funny figurine crate

@ArtisticRoomba
Copy link
Contributor Author

Science ruining my cool plans once again...

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Engineering Area: Engineering department, including Atmospherics. A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 22, 2025
@YotaXP
Copy link

YotaXP commented Jan 26, 2025

Sci ruins lots of things.

How about a power monitoring/air alarms/atmos network console? AFAIK, those aren't printable or purchasable, and would give the thief more options of where to hit.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 31, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@slarticodefast
Copy link
Member

I'll open up a maintainer discussion for this.

@ArtisticRoomba
Copy link
Contributor Author

you know how I was complaining earlier about how some random PR dropped a merge conflict pipe bomb on the repo? it was me. I dropped it in the engi guidebook update.

# Conflicts:
#	Resources/Prototypes/Entities/Structures/Power/Generation/teg.yml
@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Jan 31, 2025
@slarticodefast slarticodefast self-assigned this Jan 31, 2025
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 31, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Engineering Area: Engineering department, including Atmospherics. A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. size/S Denotes a PR that changes 10-99 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it
Projects
None yet
Development

Successfully merging this pull request may close these issues.