Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Rubber now uneatable #34543

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[FIX] Rubber now uneatable #34543

wants to merge 13 commits into from

Conversation

kosticia
Copy link
Contributor

@kosticia kosticia commented Jan 20, 2025 •
edited
Loading

Why / Balance

Closes #33152.

Requirements

Changelog
🆑
No fun, no CL

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/XS Denotes a PR that changes 0-9 lines. labels Jan 20, 2025
@lzk228
Copy link
Contributor

lzk228 commented Jan 20, 2025

no it doesn't, because it still inherits BasePlushie which has FoodComponent
plus fix the rubber duck
plus why did you add Payload tag?

@kosticia
Copy link
Contributor Author

no it doesn't, because it still inherits BasePlushie which has FoodComponent plus fix the rubber duck plus why did you add Payload tag?

Oh fuck, forgot that rubber duck exist. I'll create BaseRubberToy entity. Payload tag allows put toys in mines/bombs.

@deltanedas
Copy link
Contributor

wait til you hear about yummy traffic cones

@slarticodefast
Copy link
Member

Did you test this in-game?
Like lzk said, it still inherits the component from its parent. And I don't understand what the payload tag is supposed to do here.

@kosticia
Copy link
Contributor Author

Did you test this in-game?
Like lzk said, it still inherits the component from its parent. And I don't understand what the payload tag is supposed to do here.

Yes, it's works because BasePlushie has two tags: Payload and ClothMade. I removed ClothMade tag and toy became uneatable.

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 21, 2025
@kosticia kosticia changed the title [FIX] Rubber chicken now can't be eaten [FIX] Rubber now uneatable Jan 21, 2025
@ArtisticRoomba ArtisticRoomba added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 21, 2025
@lzk228 lzk228 mentioned this pull request Jan 24, 2025
Open
2 tasks
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. size/M Denotes a PR that changes 100-999 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plushie rubber toys
5 participants
@kosticia @lzk228 @deltanedas @slarticodefast @ArtisticRoomba