Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Fix MRP whitelist auto denying people with any medium severity notes in 14 days #34532

Merged
merged 3 commits into from
Jan 21, 2025
Merged

[HOTFIX] Fix MRP whitelist auto denying people with any medium severity notes in 14 days #34532

merged 3 commits into from
Jan 21, 2025

Conversation

ArtisticRoomba
Copy link
Contributor

About the PR

Fixes a bug causing player connection to be denied to the salamander server if the user has medium severity notes in the past 14 days.

Previously this was supposed to be more than or equal to two, however a typo caused it to be one. This issue hasn't arisen until today.

Why / Balance

Bug. Issue was discovered and relayed to me privately.

Technical details

Changes minimumNotes from 1 to 2. It was supposed to be 2 as the comment describes it.

Requirements

Changelog
No CL no fun

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Branch: Stable Intended to be merged into Stable. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. labels Jan 20, 2025
@ScarKy0 ScarKy0 added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. A: Admin Tooling Area: Admin tooling and moderation. T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on labels Jan 20, 2025
@ScarKy0
Copy link
Contributor

ScarKy0 commented Jan 20, 2025

Get triaged nerd

@slarticodefast
Copy link
Member

Are the automatic whitelists even activated yet?

@ArtisticRoomba
Copy link
Contributor Author

Are the automatic whitelists even activated yet?

Absolutely no clue. We're on a manual forum process rather than "you're in if you have (x) amount of playtime, no notes, etc".

Recently a user has been blocked from joining Mander because they "had too many recent admin notes", so the system might actually be enabled, and in this case it might need to be fixed.

@slarticodefast
Copy link
Member

Ok, looks like the automatic whitelist is still commented out, but automatic blacklisting is active.
Here the feedback from nik about the current policy:
grafik
So could you:

  • comment out the blacklisting for low severity notes
  • change the blacklisting for medium severity notes to 3 within 90 days

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines. label Jan 20, 2025
@ArtisticRoomba
Copy link
Contributor Author

git is high and obliterated the diff in some weird dark and twisted way but I promise I didn't mess anything up

@Errant-4
Copy link
Member

There is still some discussion, feel free to approve as-is, but do not merge for a couple hours/further notice

@Errant-4 Errant-4 added S: DO NOT MERGE Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft. and removed S: DO NOT MERGE Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft. labels Jan 20, 2025
@Errant-4 Errant-4 merged commit 9950648 into space-wizards:stable Jan 21, 2025
12 checks passed
slarticodefast added a commit that referenced this pull request Jan 21, 2025
@slarticodefast
Merge salamander whitelist hotfix #34532 into master (#34551)
07ad21d
widgetbeck pushed a commit to widgetbeck/imp-station-14 that referenced this pull request Jan 29, 2025
@ArtisticRoomba @widgetbeck
[HOTFIX] Fix MRP whitelist auto denying people with any medium severi…
6ba988d 
…ty notes in 14 days (space-wizards#34532)

* fix mrp whitelist auto denying people with warning

* make headmin requested changes

* godo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Errant-4 Errant-4 Errant-4 approved these changes

@Simyon264 Simyon264 Simyon264 approved these changes

@ScarKy0 ScarKy0 ScarKy0 approved these changes

Assignees
No one assigned
Labels
A: Admin Tooling Area: Admin tooling and moderation. Branch: Stable Intended to be merged into Stable. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArtisticRoomba @ScarKy0 @slarticodefast @Errant-4 @Simyon264