Fix SuperSlippery And StepTriggers persisting when UpdateSlip is called #34525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- made values in SpillTileReaction's public so we can query the prototype - made the default values for slippery component and StepTriggerComponent based on default constants for easier resetting - added a calculation and check in UpdateSlips to check if a super slip is present as well as Update relevant steptrigger and slip values based on the contents of the solution
VasilisThePikachu
approved these changes
Feb 17, 2025
ScarKy0
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Updated
PuddleSystem::UpdateSlipto change a puddles steptrigger and slippery component to reflect the contents of a puddle as the reagents within it change, such as when using a mop or Space cleaner on space lube, in response to #34303 not fully solving the issue (fixes #29229)Why / Balance
It was broken and never updated the properties of the puddle entity
Technical details
Made values in SpillTileReaction's public so we can query the
reagents prototype for those values
Made the default values for slippery component and
StepTriggerComponent based on default constants
for easier resetting
Added a calculation and check in UpdateSlips to check
if a super slip is present as well as Update
relevant steptrigger and slip values based on the contents of the
solution
Media
slipsbefore.mp4
slipsafter.mp4
Requirements
Breaking changes
Changelog
🆑 Kickguy223