Reduce network burden of thirst system #33403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks, Rider
2 tasks
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
2 tasks
MilonPL
reviewed
Jan 20, 2025
| /// This value should be updated relatively infrequently. To get the current thirst, which changes with each update, | ||
| /// use <see cref="ThirstSystem.GetThirst"/>. | ||
| /// </summary> | ||
| [DataField, ViewVariables(VVAccess.ReadOnly)] |
There was a problem hiding this comment.
Declare attributes on the same line, remove ViewVariables
There was a problem hiding this comment.
In this case, ViewVariables is necessary because it explicitly prevents this field from being edited.
# Conflicts: # Content.Shared/Nutrition/EntitySystems/ThirstSystem.cs
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Closing in favor of #34166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Replace
ThirstComponent'sCurrentThirstwithThirstSystem.GetThirst, which calculates the current thirst value from an initial value, a time when that initial value was set, and a constant decay rate.See also #32986
Why / Balance
#28070
Technical details
ThirstComponentno longer hasCurrentThirst, and instead hasLastAuthoritativeThirstValueandLastAuthoritativeThirstChangeTimeThirstComponent.CurrentThirstwithThirstSystem.GetThirst, which calculates the current thirst value by predicting the decay since the last authoritative update:LastAuthoritativeThirstValue - (IGameTiming.CurrTime - LastAuthoritativeThirstChangeTime) * ActualDecayRateThirstSystem.Updatenow only looks to update the current thirst threshold (because there's no value to update)ThirstSystem.SetAuthoritativeThirstValue, which setsLastAuthoritativeThirstValueandLastAuthoritativeThirstChangeTimeand dirties the component, causing those values to get pushed to the client, resetting the "current" calculation's basepoint.ThirstSystem.SetThirstand anything that modifies the current threshold callThirstSystem.SetAuthoritativeThirstValueto ensure any unpredictable changes are replicated to the client.Media
(With non-game-logic-altering modifications made to raise an event on
ThirstComponentreplication + popup creation when getting that event)thirst.mp4
Requirements
Breaking changes
ThirstComponent'sCurrentThirstis gone. It needs to be replaced by:ThirstSystem.GetThirstin C#lastAuthoritativeThirstValuein YAML (eg. for initial thirst values on prototypes)Changelog
Technical implementation changes, no CL.