3mo xeno archeology (first phase)

[Fildrance]

About the PR

Re-doing of xeno archeology, mostly done by legendary EmoGarbage.
This PR implements part of https://docs.spacestation14.com/en/space-station-14/departments/science/proposals/xenoarch-redux.html and creation of pathway to fully implementing this design doc, and more possibilities!

Stuff that PR is addressing:

• interaction with artifact now is much more clear - new artifact UI tells exact story and much easier to understand. Also progression through artifact is clearly visible with neat 'unlocked nodes' indication.
• new and very neat way to unlock nodes (will create much more different situations!)
• new ways node activation works makes it easier to use artifacts in civil (or military) purposes
• artifact graph generation now is parametrizable
• some effect/trigger code also were moved to shared!

Stuff that PR is not implementing:

• device to remove or add nodes
• effect-modifying nodes (like 'activate with offset x', or 'activate 2 times')
• new triggers and effects (:sadge:)
• meaningful (non-random, value-based) way that graph generator can use for choosing effect of node
• Artifact Glue
• Resequencer
• Arti-nUKer
• foam / chemicals effects should have clear description of what they will produce (exact chemical)
• guide book is not updated. shieeeee....
• amount of research points is dependent on amount of durability node have in a reverse way (less durability - more points), which contradicts idea from design doc
• most of 1-time only nodes still have more then 1 durability point (making artifact to have container, making it into a drill etc)

job done:

• new artifact system (giant refactoring, moved huge chunks to shared, artifact graph API)
• new artifact generation (quite parametrizable from yml + tests)
• new artifact analyze console UI
• migrate artifact triggers
• migrate artifact effects
• change artifaxium effect (currently removed, need to clean up and update in separate PR!)
• clean up old systems / components / prototypes
• update yml
• new node scanner

Side effects:

• Removed artifact crusher activating node (as there is no 'current' node). Maybe we are going to return it in some way shape or form later.
• Some of effects were separated from one effect with random results to effect with certain result, more predictable stuff
• Some effects disabled from being chosen on artifact generation to not mess up with new way to activate nodes
• Artifact does not have 'activate node' action for now (as it is badly blending with new node activation system)
• Mass destruction evens were removed until value-based graph generation will be introduced
• All effects now can happen on any node depth (will be changed in next PR)
• More 'obscure' effect descriptions had to be changed to more direct and easier to understand
• New point extraction mechanics is... not quite easy to understand
• Way that nodes are activated after unlocking is not really intuitive at first time

Why / Balance

Implementation of design doc to make archeology more involving, less random, introduce richer system for interactions with artifacts.

Technical details

• Artifact nodes are entities now. Triggers and effects are bound to it and usually not to artifact itself, which may be confusing in some scenarious
• XenoArtifactComponent contains references for nodes/segments using NetEntities. Due to this every request for node/edge info requires request to system, which wraps it into nice methods (AddNode, GetNodeIndex, GetNode, GetDirectPredecessorNodes, etc.) but inside it still have to iterate over EntityQuery sometimes to get required node component.
• Point made above is getting much worse due to UI calling those node-related methods on each Draw! But it somehow holds <_<
• BaseXATSystem (base type for XenoArtifactTrigger systems) is bound (kinda) to registration of Relay events in SharedXenoArtifactSystem.InitializeXAT - its not obvious, but it works.
• ReactionEntityEvent was introduced by Emo to bypass most of chemistry stuff for checking artifact triggers.
• BaseQueryUpdateXATSystem is derived from BaseXATSystem and is generally used for artifacts requiring usage of Update loop in regards of some kind of artifact state - collecting artifact dmg, covering it with gas etc.
• Graph creation algorythm was made to never re-use different triggers in one artifact. This means that graph node count is limited to max number of different triggers we have. This could be improved by creating some different sub-types of triggers, but currently this problem is not touched.

Media

https://www.youtube.com/watch?v=e-i975ANjNA

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

All old Artifact-node related components, systems and yml were changed, moved or deleted. New stuff is not 1-to-1 compatible.

Changelog

🆑 EmoGarbage404, Fildrance

• add: new ui for analysis console, new ui for node scanner. Artifact node activation is now different.
• remove: artifacts cannot create massive distruction events, become guns or music instruments. Sentient artifacts cannot activate nodes.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Fildrance]

I still have no idea how to fix PVS bugs, :pepeHands:
But in the meanwhile i added some minor balance to effects (toyed with durability amount) and also going to do some major balance changes for whole new system to feel more interesting:

1. Nodes that are unlocked and have no successors now won't listen to triggers. This will dramatically reduce complexity of node unlocking in scenarios when you unlocked 1 separated graph of nodes for artifact but you now need to also unlock the other one.
2. Node unlocking now won't activate node effect - so you should not be afraid that explosion node will break your analyzer. This will bring down level of random casualties sci provide, and i'm sad about that too, but this is the only sane way to keep one-time activatable nodes balances (coz otherwise they will ALWAYS have 2, as we cannot make durabilit a 0 and removing durability from unlocking is unfair, as unlocking should lead scientist to a prize in a form of free to use node charge!)

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Emisse]

remove mapping change from pr

[Fildrance]

remove mapping change from pr

PR contains components rename so i changed what was required for maps to load (according to tests). There was also reach tmp changes for playtest that i forgot to revert - now it is done and back to the square one, ty.

[Fildrance]

Full callstack of PVS error looks like this

Unhandled exception. System.Collections.Generic.KeyNotFoundException: Entity 0 does not have a component of type Content.Shared.Xenoarchaeology.Artifact.Components.XenoArtifactNodeComponent
   at Content.Shared.Xenoarchaeology.Artifact.SharedXenoArtifactSystem.XenoArtifactNode(EntityUid uid) in /home/beck/RiderProjects/space-station-14/Content.Shared/Xenoarchaeology/Artifact/SharedXenoArtifactSystem.Node.cs:line 39
   at Content.Shared.Xenoarchaeology.Artifact.SharedXenoArtifactSystem.GetAllNodes(Entity`1 ent)+MoveNext() in /home/beck/RiderProjects/space-station-14/Content.Shared/Xenoarchaeology/Artifact/SharedXenoArtifactSystem.Graph.cs:line 106
   at Content.Shared.Xenoarchaeology.Artifact.SharedXenoArtifactSystem.RelayEventToNodes[T](Entity`1 ent, T& args) in /home/beck/RiderProjects/space-station-14/Content.Shared/Xenoarchaeology/Artifact/SharedXenoArtifactSystem.XAT.cs:line 50
   at Robust.Shared.GameObjects.EntityEventBus.<>c__DisplayClass57_0`2.<SubscribeLocalEvent>g__EventHandler|0(EntityUid uid, IComponent comp, TEvent& args) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 324
   at Robust.Shared.GameObjects.EntityEventBus.<>c__DisplayClass67_0`1.<EntSubscribe>b__0(EntityUid uid, IComponent comp, Unit& ev) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 460
   at Robust.Shared.GameObjects.EntityEventBus.EntDispatch(EntityUid euid, Type eventType, Unit& args) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 634
   at Robust.Shared.GameObjects.EntityEventBus.RaiseLocalEventCore(EntityUid uid, Unit& unitRef, Type type, Boolean broadcast) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 240
   at Robust.Shared.GameObjects.EntityEventBus.RaiseLocalEvent[TEvent](EntityUid uid, TEvent args, Boolean broadcast) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 200
   at Robust.Shared.GameObjects.EntitySystem.RaiseLocalEvent[TEvent](EntityUid uid, TEvent args, Boolean broadcast) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntitySystem.cs:line 159
   at Content.Shared.Damage.DamageableSystem.DamageChanged(EntityUid uid, DamageableComponent component, DamageSpecifier damageDelta, Boolean interruptsDoAfters, Nullable`1 origin) in /home/beck/RiderProjects/space-station-14/Content.Shared/Damage/Systems/DamageableSystem.cs:line 111
   at Content.Shared.Damage.DamageableSystem.DamageableHandleState(EntityUid uid, DamageableComponent component, ComponentHandleState& args) in /home/beck/RiderProjects/space-station-14/Content.Shared/Damage/Systems/DamageableSystem.cs:line 280
   at Robust.Shared.GameObjects.EntityEventBus.<>c__DisplayClass56_0`2.<SubscribeLocalEvent>g__EventHandler|0(EntityUid uid, IComponent comp, TEvent& args) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 305
   at Robust.Shared.GameObjects.EntityEventBus.<>c__DisplayClass67_0`1.<EntSubscribe>b__0(EntityUid uid, IComponent comp, Unit& ev) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 460
   at Robust.Shared.GameObjects.EntityEventBus.DispatchComponent[TEvent](EntityUid euid, IComponent component, CompIdx baseType, Unit& args) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 678
   at Robust.Client.GameStates.ClientGameStateManager.HandleEntityState(EntityUid uid, NetEntity netEntity, MetaDataComponent meta, IEventBus bus, EntityState curState, EntityState nextState, GameTick lastApplied, GameTick toTick, Boolean enteringPvs) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Client/GameStates/ClientGameStateManager.cs:line 1391
   at Robust.Client.GameStates.ClientGameStateManager.ApplyEntityStates(GameState curState, GameState nextState) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Client/GameStates/ClientGameStateManager.cs:line 902
   at Robust.Client.GameStates.ClientGameStateManager.ApplyGameState(GameState curState, GameState nextState) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Client/GameStates/ClientGameStateManager.cs:line 741
   at Robust.Client.GameStates.ClientGameStateManager.ApplyGameState() in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Client/GameStates/ClientGameStateManager.cs:line 388
   at Robust.Client.GameController.Tick(FrameEventArgs frameEventArgs) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Client/GameController/GameController.cs:line 552
   at Robust.Client.GameController.<StartupContinue>b__63_0(Object sender, FrameEventArgs args) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Client/GameController/GameController.cs:line 243
   at Robust.Shared.Timing.GameLoop.Run() in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Shared/Timing/GameLoop.cs:line 240
   at Robust.Client.GameController.ContinueStartupAndLoop(DisplayMode mode) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Client/GameController/GameController.Standalone.cs:line 163
   at Robust.Client.GameController.GameThreadMain(DisplayMode mode) in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Client/GameController/GameController.Standalone.cs:line 148
   at Robust.Client.GameController.<>c__DisplayClass105_0.<Run>b__0() in /home/beck/RiderProjects/space-station-14/RobustToolbox/Robust.Client/GameController/GameController.Standalone.cs:line 107

It is being called by syncing state of damagable thingy on artifact, and most of all interesting here is that its called with negative dmg (heal) - artifacts have no such explicit mechanics, i have no idea what the hell it is. But! As states and entities are synced - i guess its fine to just use TryGetEntity instead of GetEntity that were returning Invalid EntityUid because entity was not yet synced.

[Fildrance]

Positive and negative side effect of making artifact not execute its effect on unlocking node is the fact that they are kind of safe to transport (unless radioactive or unless someone would like to not drag it but actually click on it in the hall). This opens possibilities to use them more widely as traitor, or anti-nukie, it would be quite interesting to see.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Fildrance]

As a remark - PVS bug was fixed 3 weeks ago (at least one of the problems that we got stable repro of) by that

i guess its fine to just use TryGetEntity instead of GetEntity that were returning Invalid EntityUid because entity was not yet synced.

[Fildrance]

Why oh why i belived that Elkridge from master won't contain hard-coded artifact...