Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebot Resprite #32660

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

RumiTiger
Copy link
Contributor

About the PR

Resprite firebot (its eye glows in the dark).

Why / Balance

I think the firebot needed a resprite.

Media

Firebot
image

Requirements

Breaking changes

Changelog
🆑

  • tweak: Resprite firebot

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Oct 6, 2024
Copy link
Contributor

github-actions bot commented Oct 6, 2024

RSI Diff Bot; head commit 98a172b merging into 6b62257
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Silicon/Bots/firebot.rsi

State Old New Status
firebot Modified
glow Added

Edit: diff updated after 98a172b

@Golinth
Copy link
Contributor

Golinth commented Oct 6, 2024

I dont mind the sprite, but the "eye" isn't meant to be an eye, its a status light. It will eventually need to turn yellow and red for different states of the bot.

@RumiTiger
Copy link
Contributor Author

I dont mind the sprite, but the "eye" isn't meant to be an eye, its a status light. It will eventually need to turn yellow and red for different states of the bot.

I don't see any problem with the eye. I think it looks cute and funny with it. Besides, it's just a decorative detail, nothing more

@Golinth
Copy link
Contributor

Golinth commented Oct 6, 2024

I dont mind the sprite, but the "eye" isn't meant to be an eye, its a status light. It will eventually need to turn yellow and red for different states of the bot.

I don't see any problem with the eye. I think it looks cute and funny with it. Besides, it's just a decorative detail, nothing more

I'm not saying it looks bad, just that its a status light that all of our bots have, and that in the future it will need to be colored differently, as it wont always be a decorative detail.

@Qsan163
Copy link

Qsan163 commented Oct 6, 2024

изображение

@SaphireLattice
Copy link
Contributor

I think it would be good to keep the meta.json attribution to the original asset there. Yeah it's messy, the format should be modified to support multiple attributions, some day...

@Everturning
Copy link

i dont like it, its too detailed, doesnt go with the other bots

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Art Area: Art with no implications for other areas. A: Science Area: Science department, not including Silicons. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. size/S Denotes a PR that changes 10-99 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Art Area: Art with no implications for other areas. A: Science Area: Science department, not including Silicons. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. size/S Denotes a PR that changes 10-99 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants