Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the science radio channel color #31319

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

Winkarst-cpu
Copy link
Contributor

@Winkarst-cpu Winkarst-cpu commented Aug 22, 2024

About the PR

Changed the color of the science radio channel.

Why / Balance

Resolves #30573.

Technical details

The new color is literally the screen color of the science computers.
изображение

Media

Old color

изображение

New color

изображение

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: The color of the science radio channel was changed.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Aug 22, 2024
@UbaserB
Copy link
Member

UbaserB commented Aug 22, 2024

I like it a lot more, maybe make it a tad brighter too?

@Winkarst-cpu
Copy link
Contributor Author

Winkarst-cpu commented Aug 22, 2024

I like it a lot more, maybe make it a tad brighter too?

изображение

@Winkarst-cpu
Copy link
Contributor Author

How is this a failed check?...

@slarticodefast
Copy link
Member

Looks good. Can you show a picture comparing it to the ghost chat?
I will re-run the test for you.

@Winkarst-cpu
Copy link
Contributor Author

Winkarst-cpu commented Aug 22, 2024

Looks good. Can you show a picture comparing it to the ghost chat? I will re-run the test for you.

изображение

@slarticodefast
Copy link
Member

grafik
Comparison to admin channel.

@UbaserB UbaserB added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Aug 23, 2024
@UbaserB UbaserB merged commit 982a172 into space-wizards:master Aug 26, 2024
11 checks passed
@UbaserB UbaserB removed the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Aug 26, 2024
@Winkarst-cpu Winkarst-cpu deleted the rnd-radio-color branch August 26, 2024 12:06
@faraon123223
Copy link

А как у тебя на изменение 1 строчки, ушло 2 коммита?...

@faraon123223
Copy link

А стоп, в 3 меняли 1 строчку? Повысьте им зп👏

@Winkarst-cpu
Copy link
Contributor Author

А как у тебя на изменение 1 строчки, ушло 2 коммита?...

Look into the commits, bro.

@Winkarst-cpu
Copy link
Contributor Author

А стоп, в 3 меняли 1 строчку? Повысьте им зп👏

Ты даун или что блять?

@faraon123223

This comment was marked as abuse.

@Winkarst-cpu
Copy link
Contributor Author

Успокойся. Я тебя нигде не оскорбил. Я дишь говорю, что это изменение ебать какая хуйня. Честно, чем тебе мешал старый цвет, что ты решил его поменять?

Для некоторых он был похож на цвет чата мёртвых да и, если быть честным, на него реально смотреть противно. Читай прикреплённую проблему.

@faraon123223

This comment was marked as abuse.

@space-wizards space-wizards locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Science radio text is too vibrant
4 participants