Last Message Before Death Webhook. #30235

VelonacepsCalyxEggs · 2024-07-21T18:11:42Z

About the PR

This PR introduces an optional webhook feature that sends the last in-character (IC) messages of dead players before their death at the end of the round.

Why / Balance

This feature is added mainly for fun, I have taken inspiration from a simillar webhook on a SS13 server.
It doesn’t have a specific reason, but could add an amusing element to the game by capturing players’ final words.

Technical details

This is my first PR involving C#. So, if I did anything wrong, I will be glad to learn and improve.

The implementation works as follows:

When TrySendInGameICMessage is called in ChatSystem.cs, it checks if the player sent the message.
The message is then added or updated in the dictionary located in LastMessageBeforeDeath.cs.
At the end of the round, onRoundEnd is called from GameTicker.RoundFlow to send the message using a webhook.

This feature is only active if the webhook link is specified in server_config.toml.

Media

[ x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

~~I know it says After Death on the image... I am dumb.~~

Changelog

🆑 func_kenobi

add: Added an optional Webhook that will send messages said by players before their death at the end of the round.

Signed-off-by: VelonacepsCalyxEggs <ivankuvaev777@gmail.com>

Emisse · 2024-07-21T18:44:58Z

very fun

Content.Server/Chat/LastMessageBeforeDeath.cs

Content.Server/GameTicking/GameTicker.CVars.cs

Content.Server/Chat/LastMessageBeforeDeath.cs

- Added conditional compilation for Debugging. - Webhook is no longer exposed to VV. - Now using an ordered dict. - Message is now formatted. - Time is now trunucated. - Now checking for maximum size and splitting the message (2000). - Prevention of a ratelimit if more than 30 messages are sent.

Content.Server/Chat/LastMessageBeforeDeath.cs

Content.Server/GameTicking/GameTicker.CVars.cs

addressed

Remove the leftover [ViewVariables] (I am blind). Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

- All hardcoded variables are now constants. (well not all, all that needed to be) - If the message exceeds the MaxICLength, it will be cut off at a random interval. Example: Someone was giving a speech and got blown to bits. IC: "I am giving a very interesting 1000 character long spee-" - Made sure the messages don't get split in half. - Added a delay between messages.

…on-14 into deathwebhook

…/space-station-14 into deathwebhook

VelonacepsCalyxEggs · 2024-07-22T15:23:54Z

I have encountered a problem, IGameTiming.CurTime seems to be the time of how long the server has been up, and not the round time.
Where can I get the round time from instead?

EmoGarbage404 · 2024-07-22T15:24:20Z

I have encountered a problem, IGameTiming.CurTime seems to be the time of how long the server has been up, and not the round time. Where can I get the round time from instead?

GameTicker has it

Signed-off-by: VelonacepsCalyxEggs <ivankuvaev777@gmail.com>

fixed a place where a constant was not used.

VelonacepsCalyxEggs · 2024-07-27T13:56:32Z

I have only one concern as of now.

What if a player says something inapropriate, and gets kicked / banned from the game? Player's message will still stay in the pool.
I not sure if I should be worried about this or not.
But if I need to implement this, I would probably go about it like this:
Remove the EntityUid of the player from the dict when he gets kicked/banned.

But I didn't really look at any admin code, so... not sure how I would go about implementing that without touching some sacred code.

Chief-Engineer · 2024-07-27T14:42:51Z

When someone is banned or kicked you could just call a method that finds and removes their message from the message list

VelonacepsCalyxEggs · 2024-07-27T16:12:28Z

When someone is banned or kicked you could just call a method that finds and removes their message from the message list

Oh, so I suppose there is an event listener for that, that also returns the player's uid when someone is kicked/banned?
I will look into it.

Chief-Engineer · 2024-07-27T19:40:23Z

I'm not sure if there's an existing event for those or not, but it should be fairly easy to make an event if it's needed

VelonacepsCalyxEggs · 2024-07-28T09:35:48Z

I'm not sure if there's an existing event for those or not, but it should be fairly easy to make an event if it's needed

So... uhh... I've asked around and looked around, and I don't think there are event listeners for that.
Should I open a separate PR for this or... just jam it in here?

Chief-Engineer · 2024-07-28T12:45:30Z

You can just add them with this if they'll be used by this PR

I had to add an event listener for bans, it seems to work. But I am not sure I did it properly. Also some minor fixes, like whisper and emote not registering properly. Signed-off-by: VelonacepsCalyxEggs <ivankuvaev777@gmail.com>

…on-14 into deathwebhook

…/space-station-14 into deathwebhook

PJB3005

Haven't fully reviewed this but well here's enough to keep you busy.

Content.Server/Chat/Systems/ChatSystem.cs

PJB3005 · 2024-10-30T02:10:16Z

Content.Server/Chat/Systems/LastMessageBeforeDeathSystem.cs

+        private static LastMessageBeforeDeathSystem? _instance;
+        private static readonly object _lock = new object();
+
+        private static readonly Random _random = new Random();


This is still not fixed.

Content.Server/Chat/Systems/LastMessageBeforeDeathSystem.cs

Content.Server/Discord/Managers/LastMessageWebhookManager.cs

Content.Server/Chat/Systems/LastMessageBeforeDeathSystem.cs

Content.Server/Chat/Systems/ChatSystem.cs

github-actions · 2024-11-13T19:04:21Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-11-13T19:04:21Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-11-25T12:55:40Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

VelonacepsCalyxEggs · 2024-11-25T15:38:11Z

I'll get back to this soon. Just in case.

# Conflicts: # Content.Server/Administration/Managers/IBanManager.cs # Content.Shared/CCVar/CCVars.cs Added a webhook related CCVar in Content.Shared/CCVar/CCVars.Discord.cs

Now using mind to get the Character Name to avoid obfuscation. Added all constants as CVars. Webhook CVar is now tracked fully in the LastMessage system. Removed unneeded junk.

VelonacepsCalyxEggs · 2024-12-15T21:37:12Z

I think I did everything specified in the review, but I am not sure about some things, specifically not storing ICommonSession, I need to store it to check whenever the player was banned or kicked during their gameplay, which would disqualify them from getting into the webhook, but, that also could mean that if a player looses connection and reconnects, they would be disqualified too, I need a way to check directly by NetUserId, because it is persistent, I was thinking of checking if there is a mind linked to this NetUserId, but I am not sure what happens to a player's mind when they disconnect.

I need some advice on this.

github-actions · 2025-01-15T01:20:07Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

VelonacepsCalyxEggs added 2 commits July 21, 2024 20:47

Added a new webhook to track player's last IC message.

2c3852e

Signed-off-by: VelonacepsCalyxEggs <ivankuvaev777@gmail.com>

Code cleanup.

1817c59

Signed-off-by: VelonacepsCalyxEggs <ivankuvaev777@gmail.com>

VelonacepsCalyxEggs requested a review from EmoGarbage404 as a code owner July 21, 2024 18:11

github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jul 21, 2024

Emisse requested a review from Chief-Engineer July 21, 2024 18:45

VelonacepsCalyxEggs changed the title ~~Last Message After Death Webhook.~~ Last Message Before Death Webhook. Jul 22, 2024

Chief-Engineer previously requested changes Jul 22, 2024

View reviewed changes

VelonacepsCalyxEggs requested a review from Chief-Engineer July 22, 2024 11:38

Chief-Engineer reviewed Jul 22, 2024

View reviewed changes

VelonacepsCalyxEggs and others added 4 commits July 22, 2024 18:15

Update Content.Server/GameTicking/GameTicker.CVars.cs

1f1fce8

Remove the leftover [ViewVariables] (I am blind). Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

Merge branch 'master' of https://github.com/space-wizards/space-stati…

73b607f

…on-14 into deathwebhook

Merge branch 'deathwebhook' of https://github.com/VelonacepsCalyxEggs…

96aeb27

…/space-station-14 into deathwebhook

VelonacepsCalyxEggs and others added 2 commits July 22, 2024 18:43

Use GameTicker instead of IGameTiming.

fcc8a9c

Signed-off-by: VelonacepsCalyxEggs <ivankuvaev777@gmail.com>

Convention check

88bdb6a

fixed a place where a constant was not used.

VelonacepsCalyxEggs added 3 commits July 29, 2024 02:47

Remove message on ban.

6658722

I had to add an event listener for bans, it seems to work. But I am not sure I did it properly. Also some minor fixes, like whisper and emote not registering properly. Signed-off-by: VelonacepsCalyxEggs <ivankuvaev777@gmail.com>

Merge branch 'master' of https://github.com/space-wizards/space-stati…

d59f327

…on-14 into deathwebhook

Merge branch 'deathwebhook' of https://github.com/VelonacepsCalyxEggs…

760dc71

…/space-station-14 into deathwebhook

VelonacepsCalyxEggs requested a review from DrSmugleaf as a code owner July 28, 2024 23:51

PJB3005 self-assigned this Oct 30, 2024

PJB3005 requested changes Oct 30, 2024

View reviewed changes

github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Nov 13, 2024

SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024

github-actions bot added the Merge Conflict label Nov 25, 2024

Merge remote-tracking branch 'upstream/master' into deathwebhook

53f2c99

# Conflicts: # Content.Server/Administration/Managers/IBanManager.cs # Content.Shared/CCVar/CCVars.cs Added a webhook related CCVar in Content.Shared/CCVar/CCVars.Discord.cs

github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Nov 25, 2024

VelonacepsCalyxEggs and others added 2 commits December 15, 2024 23:44

Merge branch 'space-wizards:master' into deathwebhook

00ff25c

Now keying the user by NetUserId and their character by Mind.

1ef259a

Now using mind to get the Character Name to avoid obfuscation. Added all constants as CVars. Webhook CVar is now tracked fully in the LastMessage system. Removed unneeded junk.

VelonacepsCalyxEggs requested a review from PJB3005 December 16, 2024 16:14

github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Dec 16, 2024

github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 15, 2025

Merge branch 'master' into deathwebhook

57181e4

github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted size/L Denotes a PR that changes 1000-4999 lines. labels Jan 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Last Message Before Death Webhook. #30235

Last Message Before Death Webhook. #30235

VelonacepsCalyxEggs commented Jul 21, 2024 •

edited

Loading

Emisse commented Jul 21, 2024

VelonacepsCalyxEggs commented Jul 22, 2024

EmoGarbage404 commented Jul 22, 2024

VelonacepsCalyxEggs commented Jul 27, 2024

Chief-Engineer commented Jul 27, 2024

VelonacepsCalyxEggs commented Jul 27, 2024

Chief-Engineer commented Jul 27, 2024

VelonacepsCalyxEggs commented Jul 28, 2024 •

edited

Loading

Chief-Engineer commented Jul 28, 2024

PJB3005 left a comment

PJB3005 Oct 30, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 25, 2024

VelonacepsCalyxEggs commented Nov 25, 2024

VelonacepsCalyxEggs commented Dec 15, 2024

github-actions bot commented Jan 15, 2025

Last Message Before Death Webhook. #30235

Are you sure you want to change the base?

Last Message Before Death Webhook. #30235

Conversation

VelonacepsCalyxEggs commented Jul 21, 2024 • edited Loading

About the PR

Why / Balance

Technical details

Media

Emisse commented Jul 21, 2024

VelonacepsCalyxEggs commented Jul 22, 2024

EmoGarbage404 commented Jul 22, 2024

VelonacepsCalyxEggs commented Jul 27, 2024

Chief-Engineer commented Jul 27, 2024

VelonacepsCalyxEggs commented Jul 27, 2024

Chief-Engineer commented Jul 27, 2024

VelonacepsCalyxEggs commented Jul 28, 2024 • edited Loading

Chief-Engineer commented Jul 28, 2024

PJB3005 left a comment

Choose a reason for hiding this comment

PJB3005 Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 25, 2024

VelonacepsCalyxEggs commented Nov 25, 2024

VelonacepsCalyxEggs commented Dec 15, 2024

github-actions bot commented Jan 15, 2025

VelonacepsCalyxEggs commented Jul 21, 2024 •

edited

Loading

VelonacepsCalyxEggs commented Jul 28, 2024 •

edited

Loading