Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radiation Collector improvements #20953

Closed
2 tasks done
keronshb opened this issue Oct 12, 2023 · 7 comments
Closed
2 tasks done

Radiation Collector improvements #20953

keronshb opened this issue Oct 12, 2023 · 7 comments
Labels
Changes: Map Changes: Might require knowledge of mapping. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content

Comments

@keronshb
Copy link
Contributor

keronshb commented Oct 12, 2023

  • Radiation collectors should have a new sprite to indicate full/empty plasma & maps should spawn a single plasma tank on one. Radiation collector sprite update #20956
  • Engineering should be mapped with an oxy/plasma tank dispenser that has 10 oxygen tanks and 10 plasma tanks

- The old TG sprite could be used since it had a slot for an inserted plasma tank.
- An alert can be sent out over the engineering radio if the plasma is low/run out.

@keronshb keronshb added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content Changes: Map Changes: Might require knowledge of mapping. D3: Low Difficulty: Some codebase knowledge required. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Oct 12, 2023
@chromiumboy
Copy link
Contributor

I'm happy to take on the add on plasma tank sprite for the collector and the code to update its appearance

The clarify, should the collector spawn with a full tank inside it, or should a full tank be mapped on top of the collector? My recollection was the latter

Also, if you have a set up with 12 radiation collectors, it could get the radio could be spammed with a dozen messages if they all run low on gas within a short period of time

@keronshb
Copy link
Contributor Author

The clarify, should the collector spawn with a full tank inside it, or should a full tank be mapped on top of the collector? My recollection was the latter

Back in SS13 a plasma tank would be mapped to spawn on top of a rad collector. Sort of like a hint for the player to put it in the collector, and then do the same for the rest.

Also, if you have a set up with 12 radiation collectors, it could get the radio could be spammed with a dozen messages if they all run low on gas within a short period of time

That's a potential issue since the likeliness of them all getting set at the same time is high. And then what happens if someone else outside of engineering makes a plasma collector. That shouldn't alert engineering if the plasma was low either.

The ones in engineering could be linked to the engineering/atmos channels and then the first one gets to report? It could start a timer or something so the others don't report within x amount of seconds of the first report, but that could get tricky.

@chromiumboy
Copy link
Contributor

chromiumboy commented Oct 13, 2023

My feeling is that there shouldn't be a radio alert for radiation collectors. It'd be like if a portable generator ran out of fuel. You need to be proactive and keep an eye on it. There will be indicator lights on the collectors too, to show the amount of plasma left in the tank. So a cursory walk around the perimeter of the singulo will be enough to see if you need to top them up

Edit: here's a mock up https://discord.com/channels/310555209753690112/346743671787356160/1158793295124770969

@keronshb
Copy link
Contributor Author

My feeling is that there shouldn't be a radio alert for radiation collectors. It'd be like if a portable generator ran out of fuel. You need to be proactive and keep an eye on it. There will be indicator lights on the collectors too, to show the amount of plasma left in the tank. So a cursory walk around the perimeter of the singulo will be enough to see if you need to top them up

Edit: here's a mock up https://discord.com/channels/310555209753690112/346743671787356160/1158793295124770969

Sounds fine to me. This gives engineers a reason to check in on the engine again.

I do miss the old TG sprite but I can live with the one we have. The sprite edit looks fine to me, actually ends up being more noticeable than the old sprite.

@keronshb
Copy link
Contributor Author

Now we just need someone to go through the maps and map a single plasma tank over one of the rad collectors. Low priority though.

@chromiumboy
Copy link
Contributor

Now we just need someone to go through the maps and map a single plasma tank over one of the rad collectors. Low priority though.

Mappers will also need to replace the default radiation collector with the version which has no attached plasma tank; at present they start with an attached (empty) tank

@UbaserB
Copy link
Member

UbaserB commented Dec 13, 2023

This should be closed

@Emisse Emisse closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Map Changes: Might require knowledge of mapping. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

No branches or pull requests

4 participants