-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AtmosPipeColor stuff should just be prototypes #13068
Comments
Do you want all the used colors to be prototypes? So teal, blue, red, brown, purple? And for vents, passive vents, mixers, filters, pumps, volume pumps, valves, passive gates, scrubbers, injectors, pneumatic valves, etc? Because that's gunna make the entity list absolutely balls to work with for atmos devices |
Yea, no, Vera, me, and probably every mapper do not want this. |
Bloating the entity list & making mapping a pain seems like its more of a mapping tools issue, so if anything this should probably just be deferred until better pipe colouring support is added? Because it is still true that this just bloats map files & should probably be using prototypes if possible. |
We will make the tooling better before doing it but don't close performance issues. |
If this is done, please make sure you come up with another way to check if a grid has disconnected networks, because the way it currently works the command colornetwork is the only sensible way to do that. |
It's at least 5,000+ wasted yaml lines per high-pop map.
The text was updated successfully, but these errors were encountered: