Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtmosPipeColor stuff should just be prototypes #13068

Open
Tracked by #20951
metalgearsloth opened this issue Dec 18, 2022 · 5 comments
Open
Tracked by #20951

AtmosPipeColor stuff should just be prototypes #13068

metalgearsloth opened this issue Dec 18, 2022 · 5 comments
Labels
D2: Medium Difficulty: A good amount of codebase knowledge required. T: Performance Type: Performance impacting changes or bugs

Comments

@metalgearsloth
Copy link
Contributor

It's at least 5,000+ wasted yaml lines per high-pop map.

@metalgearsloth metalgearsloth added T: Performance Type: Performance impacting changes or bugs D2: Medium Difficulty: A good amount of codebase knowledge required. labels Dec 18, 2022
@Cheackraze
Copy link
Contributor

Do you want all the used colors to be prototypes? So teal, blue, red, brown, purple? And for vents, passive vents, mixers, filters, pumps, volume pumps, valves, passive gates, scrubbers, injectors, pneumatic valves, etc? Because that's gunna make the entity list absolutely balls to work with for atmos devices

@moonheart08
Copy link
Contributor

Yea, no, Vera, me, and probably every mapper do not want this.
Heavily bloats the entity list, makes mapping more of a pain, etc.

@ElectroJr
Copy link
Member

Bloating the entity list & making mapping a pain seems like its more of a mapping tools issue, so if anything this should probably just be deferred until better pipe colouring support is added? Because it is still true that this just bloats map files & should probably be using prototypes if possible.

@metalgearsloth
Copy link
Contributor Author

Yea, no, Vera, me, and probably every mapper do not want this.
Heavily bloats the entity list, makes mapping more of a pain, etc.

We will make the tooling better before doing it but don't close performance issues.

@IProduceWidgets
Copy link
Contributor

If this is done, please make sure you come up with another way to check if a grid has disconnected networks, because the way it currently works the command colornetwork is the only sensible way to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D2: Medium Difficulty: A good amount of codebase knowledge required. T: Performance Type: Performance impacting changes or bugs
Projects
None yet
Development

No branches or pull requests

7 participants