-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] refactor LCA_Database to support programmatic creation. #946
Conversation
Co-Authored-By: Luiz Irber <luizirber@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #946 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 71 71
Lines 5021 5021
=======================================
Hits 4614 4614
Misses 407 407 Continue to review full report at Codecov.
|
…nto refactor/lca_db_create
Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
yay!! |
#942 made it clear that programmatic creation of LCAs was ...lacking. This PR refactors the
LCA_Database
class by moving functionality fromcommand_index
into theLCA_Database
class. It also provides incremental insertion of new signatures and brings the API further into line with the basicIndex
API.TODO:
sourmash index
as alternative tosourmash lca index
, or punt to issue (=> moved to support LCA/revindex database creation insourmash index
? #949)make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?