MRG: fix tutorial notebook links #2633
Merged
+133
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #2633 +/- ##
==========================================
+ Coverage 85.26% 92.83% +7.57%
==========================================
Files 133 104 -29
Lines 15157 12389 -2768
Branches 2612 2612
==========================================
- Hits 12923 11501 -1422
+ Misses 1933 587 -1346
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. see 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
ready for review & merge, @sourmash-bio/devs ! |
…o fix/tutorial-nb
|
bump @ccbaumler @bluegenes |
|
The binder do not launch to the notebooks. |
thanks! fixed in 0e17b6e. |
ccbaumler
reviewed
Jun 22, 2023
ccbaumler
reviewed
Jun 22, 2023
|
ok! This should be ready for review again, @ccbaumler - thx :) |
|
oh, sorry, didn't see the latest comments! please hold :) |
Co-authored-by: ccbaumler <63077899+ccbaumler@users.noreply.github.com>
|
ready @ccbaumler ! |
|
LGTM |
|
thank you!! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2604
This PR fixes links to binder tutorials that apparently have been broken since 2020 😱 , when the docs were switched over to myst-parser in #1021.
To be fair, it's the kind of subtle bug that would leave users scratching their head going "maybe it's me?" - the links simply went back to the tutorial page... not sure why they weren't flagged by sphinx or myst-parser as being bad!?
This PR also updates environment.yml to properly build:
ref #2503 for why specifying the minimum sourmash and/or python versions can be important!
And, finally, I ran and fixed all the notebooks...
Note: I confirmed that this branch launches properly in binder. The URL is: https://mybinder.org/v2/gh/sourmash-bio/sourmash/fix/tutorial-nb