Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makefile and docs #2432

Merged
merged 4 commits into from
Feb 18, 2023
Merged

Update makefile and docs #2432

merged 4 commits into from
Feb 18, 2023

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Jan 5, 2023

Closes #2431

Relevant to #2425 because it removes setuptools_scm from docs =P

Also brings in the pyproject.toml changes needed for #2386 (and will remove them from there)

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #2432 (35c2904) into latest (48bc344) will increase coverage by 7.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #2432      +/-   ##
==========================================
+ Coverage   84.56%   92.52%   +7.96%     
==========================================
  Files         132      103      -29     
  Lines       15486    11937    -3549     
  Branches     2503     2503              
==========================================
- Hits        13096    11045    -2051     
+ Misses       2088      590    -1498     
  Partials      302      302              
Flag Coverage Δ
python 92.52% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/index/bigsi.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/index/search.rs
src/core/src/index/sbt/mod.rs
src/core/src/ffi/index/revindex.rs
src/core/src/ffi/hyperloglog.rs
src/core/src/signature.rs
src/core/tests/minhash.rs
src/core/src/encodings.rs
src/core/src/ffi/mod.rs
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@luizirber luizirber changed the title [WIP] Update makefile and docs Update makefile and docs Feb 12, 2023
@luizirber luizirber marked this pull request as ready for review February 12, 2023 23:28
@luizirber luizirber requested a review from a team February 12, 2023 23:28
@luizirber
Copy link
Member Author

Ready for review and merge @sourmash-bio/devs

@ctb can you try this with your workflow and see if the make commands work now?

Comment on lines +7 to +8
[profile.test]
opt-level = 1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this one in too, because the tests run MUCH faster (and compile time is about the same)

Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thank you! Let me know if you'd like me to update and merge; I think you prefer to rebase?

@luizirber luizirber enabled auto-merge (squash) February 18, 2023 05:49
@luizirber luizirber merged commit 7f9ca67 into latest Feb 18, 2023
@luizirber luizirber deleted the lirber/make_fixes branch February 18, 2023 05:59
@ctb ctb mentioned this pull request Mar 3, 2023
ctb added a commit that referenced this pull request Mar 3, 2023
# sourmash release 4.7.0

Major new features:

* provide an initial plugin architecture for sourmash that supports new
signature saving & loading mechanisms (#2428)
* add plugin support for new command-line subcommands (#2438)
* debias all containment values (#2243)

Minor new features:

* Use RankLineageInfo to simplify reading lineages (#2467)
* store taxids in lineageDB (#2466)
* Use new tax classes for taxonomic summarization (#2443)
* add tax summarization dataclasses for safety and flexibility (#2439)
* add `--scaled` to sourmash compare (#2414)
* replace `lca_utils.LineagePair` with `tax_utils.LineagePair` (#2441)
* Add new classes for lineage manipulation (#2437)

Cleanup and documentation updates:

* ReadTheDocs updates (#2445)
* update `sourmash compare` command-line docs (#2400)

Developer updates:

* fix python tests by bumping tox and pip cache versions (#2424)
* Update sphinx requirement from <6,>=4.4.0 to >=4.4.0,<7 (#2430)
* Build: replace milksnake with maturin (#2393)
* importlib_metadata is a dependency on old Python versions (#2484)
* Release docs: use two separate sed commands (#2483)
* minor fixes to release behavior (#2479)
* Use screed and maturin from nixpkgs in `flake.nix` (#2481)
* update release procedure after v4.6.0 and v4.6.1 (#2386)
* Update makefile and docs (#2432)

Dependabot updates:

* Bump once_cell from 1.17.0 to 1.17.1 (#2488)
* Bump ouroboros from 0.15.5 to 0.15.6 (#2487)
* Bump memmap2 from 0.5.8 to 0.5.9 (#2486)
* Bump supercharge/redis-github-action from 1.4.0 to 1.5.0 (#2485)
* Bump proptest from 1.0.0 to 1.1.0 (#2460)
* Bump web-sys from 0.3.60 to 0.3.61 (#2461)
* Bump serde_json from 1.0.91 to 1.0.93 (#2471)
* Bump wasm-bindgen-test from 0.3.33 to 0.3.34 (#2463)
* Bump cachix/install-nix-action from 18 to 19 (#2459)
* Bump wasm-bindgen from 0.2.83 to 0.2.84 (#2464)
* Bump typed-builder from 0.11.0 to 0.12.0 (#2451)
* Bump bumpalo from 3.9.1 to 3.12.0 (#2450)
* Bump pypa/cibuildwheel from 2.11.4 to 2.12.0 (#2447)
* Bump bzip2 from 0.4.3 to 0.4.4 (#2444)
* Bump once_cell from 1.14.0 to 1.17.0 (#2429)
* Bump serde from 1.0.151 to 1.0.152 (#2423)
* Bump pypa/cibuildwheel from 2.11.3 to 2.11.4 (#2422)
* Bump serde_json from 1.0.89 to 1.0.91 (#2418)
* Bump serde from 1.0.150 to 1.0.151 (#2419)
* Bump thiserror from 1.0.37 to 1.0.38 (#2417)
* Bump finch from 0.4.3 to 0.5.0 (#2416)
* Bump rayon from 1.6.0 to 1.6.1 (#2404)
* Bump serde from 1.0.149 to 1.0.150 (#2403)
* Bump pypa/cibuildwheel from 2.11.2 to 2.11.3 (#2402)
* Bump serde from 1.0.148 to 1.0.149 (#2397)
* Bump capnp from 0.14.5 to 0.14.11 (#2396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

several make targets no longer work
2 participants