Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] disable the fix_lint component of the py38 tests in tox.ini #1823

Merged
merged 3 commits into from
Feb 3, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Feb 3, 2022

The fix_lint set of tests is causing CI to fail:

tox: fix_lint - format the code base to adhere to our styles, and complain about what we cannot do automatically
  fix_lint installdeps: pre-commit>=2
  fix_lint installed: cfgv==3.3.1,distlib==0.3.4,filelock==3.4.2,identify==2.4.7,nodeenv==1.6.0,platformdirs==2.4.1,pre-commit==2.17.0,PyYAML==6.0,six==1.16.0,toml==0.10.2,virtualenv==20.13.0
  fix_lint run-test-pre: PYTHONHASHSEED='727383646'
  fix_lint run-test: commands[0] | pre-commit run --all-files --show-diff-on-failure
  [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
  [INFO] Initializing environment for https://github.com/akaihola/darker.
  [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
  [INFO] Once installed this environment will be reused.
  [INFO] This may take a few minutes...
  [INFO] Installing environment for https://github.com/akaihola/darker.
  [INFO] Once installed this environment will be reused.
  [INFO] This may take a few minutes...
  Check python ast.........................................................Passed
  Check docstring is first.................................................Passed
  Check for merge conflicts................................................Passed
  Check Yaml...............................................................Passed
  Check Toml...............................................................Passed
  Debug Statements (Python)................................................Passed
  darker...................................................................Failed
  - hook id: darker
  - exit code: 1
  
  Traceback (most recent call last):
    File "/Users/runner/.cache/pre-commit/repokh7g6im_/py_env-python3/bin/darker", line 8, in <module>
      sys.exit(main())
    File "/Users/runner/.cache/pre-commit/repokh7g6im_/py_env-python3/lib/python3.8/site-packages/darker/__main__.py", line 196, in main
      args, config, config_nondefault = parse_command_line(argv)
    File "/Users/runner/.cache/pre-commit/repokh7g6im_/py_env-python3/lib/python3.8/site-packages/darker/command_line.py", line 163, in parse_command_line
      config = load_config(args.src)
    File "/Users/runner/.cache/pre-commit/repokh7g6im_/py_env-python3/lib/python3.8/site-packages/darker/config.py", line 37, in load_config
      path = find_project_root(tuple(srcs or ["."])) / "pyproject.toml"
  TypeError: unsupported operand type(s) for /: 'tuple' and 'str'

I can't replicate the problem locally, and it doesn't seem worth chasing down a problem that occurs in what seems to be an unreleased version of the darker package (which also isn't passing its own tests?).

So, I'm disabling it.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1823 (61b2c2c) into latest (9083d20) will increase coverage by 6.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1823      +/-   ##
==========================================
+ Coverage   83.48%   90.15%   +6.67%     
==========================================
  Files         113       87      -26     
  Lines       12183     8482    -3701     
  Branches     1627     1627              
==========================================
- Hits        10171     7647    -2524     
+ Misses       1754      577    -1177     
  Partials      258      258              
Flag Coverage Δ
python 90.15% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/cli/compute.py 100.00% <ø> (ø)
src/sourmash/cli/sig/split.py 100.00% <ø> (ø)
src/sourmash/cli/sketch/dna.py 100.00% <ø> (ø)
src/sourmash/cli/sketch/protein.py 100.00% <ø> (ø)
src/sourmash/cli/sketch/translate.py 100.00% <ø> (ø)
src/core/src/index/search.rs
src/core/src/sketch/hyperloglog/estimators.rs
src/core/src/ffi/minhash.rs
src/core/src/ffi/utils.rs
src/core/src/index/sbt/mhbt.rs
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9083d20...61b2c2c. Read the comment docs.

@ctb ctb changed the title [WIP] disable the fix_lint component of the py38 tests in tox.ini [MRG] disable the fix_lint component of the py38 tests in tox.ini Feb 3, 2022
@ctb
Copy link
Contributor Author

ctb commented Feb 3, 2022

ready for review @sourmash-bio/devs! Upon merge I will create an issue to revisit and perhaps re-enable the fix_lint tests at a later date.

@ctb ctb merged commit d361539 into latest Feb 3, 2022
@ctb ctb deleted the disable/fix_lint branch February 3, 2022 15:00
@ctb
Copy link
Contributor Author

ctb commented Feb 3, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants