-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] check to make sure that .zip files exist before trying to load from them. #1777
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1777 +/- ##
==========================================
+ Coverage 83.49% 90.19% +6.69%
==========================================
Files 113 87 -26
Lines 12159 8463 -3696
Branches 1621 1622 +1
==========================================
- Hits 10152 7633 -2519
+ Misses 1749 572 -1177
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ready for review (and, assuming tests pass, merge :) -- @sourmash-bio/devs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I reran the Python tests. |
k - looks like the tests are failing for legitimate reasons now :). so I gotta fix that. |
This PR changes
ZipStorage.load(...)
to check to see if a zipfile exists before trying to open it. In turn, this means that an empty zipfile will no longer be created byZipStorage
:)Fixes #1774