Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in sourmash.load_file_as_signatures(...) when loading non-existent .zip file #1774

Closed
ctb opened this issue Dec 22, 2021 · 1 comment · Fixed by #1777
Closed

bug in sourmash.load_file_as_signatures(...) when loading non-existent .zip file #1774

ctb opened this issue Dec 22, 2021 · 1 comment · Fixed by #1777

Comments

@ctb
Copy link
Contributor

ctb commented Dec 22, 2021

This:

sourmash.load_file_as_signatures('foo87878.zip')

yields a confusing error about manifests, when foo87878.zip doesn't exist. I think it should instead say "this file doesn't exist" 😄

@ctb
Copy link
Contributor Author

ctb commented Dec 24, 2021

Even easier,

sourmash sig describe foo87878.zip

produces a long traceback, ending with:

...
  File "/Users/t/dev/sourmash/src/sourmash/index.py", line 526, in __init__
    self._load_manifest()
  File "/Users/t/dev/sourmash/src/sourmash/index.py", line 538, in _load_manifest
    manifest_data = self.storage.load('SOURMASH-MANIFEST.csv')
  File "/Users/t/dev/sourmash/src/sourmash/sbt_storage.py", line 210, in load
    raise FileNotFoundError(path)
FileNotFoundError: SOURMASH-MANIFEST.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant