-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce transformChanges
to campaign spec (RFC 265)
#398
Conversation
a024399
to
a52e9e9
Compare
Just updated this to use the |
a52e9e9
to
b635d03
Compare
ceb46fa
to
a5269a2
Compare
@sourcegraph/campaigns @rrhyne This is now ready for review. Please see the PR description for what's included and what's not. Documentation and schema update in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Co-authored-by: Adam Harvey <aharvey@sourcegraph.com>
* Add transformChanges to campaign spec * Update Executor integration test * Add a failing test for code transformations * Change execution cache to only cache diffs * Rename from .patch to .diff * Extract groupFileDiffs function * Add test for GroupFileDiffs * Add some comments * Fix campaign progress printer for multiple changeset specs * Display how many changeset specs were produced in one repo * Add more tests for grouping changes * Fix problems after rebase * Switch from branchSuffix to branch * Add a repository filter to the transformChanges.Group * Check whether transformChanges is supported * Validate that multiple changesets don't have same branch * Add minLength to campaign spec * Pluralize message correctly * Update internal/campaigns/executor.go Co-authored-by: Adam Harvey <aharvey@sourcegraph.com> * Update feature date * Add a changelog entry Co-authored-by: Adam Harvey <aharvey@sourcegraph.com>
This is the implementation of the suggested solution for Option B in RFC 265: Multiple changesets per repository to produce multiple changesets in a single repository.
It depends on https://github.com/sourcegraph/sourcegraph/pull/16235. It fixes https://github.com/sourcegraph/sourcegraph/issues/14970.
IMPORTANT: this only implements the first step in "Defintion of success". It does not yet implement addressing multiple changesets in the same repository separately (that's Part2 in the RFC).
What this does is to introduce the
transformChanges
property to campaign specs (see https://github.com/sourcegraph/sourcegraph/pull/16235 for schema change on server).Here is an example campaign spec using it:
Changelog of this PR
branch
property instead ofbranchSuffix
to incorporate feedback on RFC 265.repository
attribute to thegroup
.