Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Add transformChanges to campaign spec and document it #16235

Merged
merged 6 commits into from
Dec 11, 2020

Conversation

mrnugget
Copy link
Contributor

@mrnugget mrnugget commented Nov 30, 2020

This mirrors the schema changes in sourcegraph/src-cli#398 and is a requirement for merging it.

This also documents transformChanges in the campaign spec YAML reference.

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #16235 (7cb46b7) into main (4b17a4a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #16235      +/-   ##
==========================================
- Coverage   52.50%   52.49%   -0.01%     
==========================================
  Files        1689     1689              
  Lines       84489    84489              
  Branches     7672     7676       +4     
==========================================
- Hits        44359    44356       -3     
- Misses      36230    36231       +1     
- Partials     3900     3902       +2     
Flag Coverage Δ
go 51.94% <ø> (-0.01%) ⬇️
integration 29.67% <ø> (-0.02%) ⬇️
storybook 27.96% <ø> (ø)
typescript 53.83% <ø> (+<0.01%) ⬆️
unit 34.67% <ø> (ø)
Impacted Files Coverage Δ
.../internal/codeintel/resolvers/graphql/locations.go 81.44% <0.00%> (-4.13%) ⬇️
client/web/src/platform/context.ts 68.75% <0.00%> (+3.12%) ⬆️

@mrnugget mrnugget force-pushed the mrn/transform-changes branch from 022930f to bcb5359 Compare December 2, 2020 14:04
@mrnugget mrnugget force-pushed the mrn/transform-changes branch from f0ae383 to 1e7f4bd Compare December 9, 2020 15:18
@mrnugget mrnugget changed the title Extend CampaignSpec schema with transformChanges Add transformChanges to campaign spec and document it Dec 10, 2020
@mrnugget mrnugget marked this pull request as ready for review December 10, 2020 14:21
@mrnugget
Copy link
Contributor Author

@sourcegraph/campaigns @rrhyne Marking this as ready-for-review since it's a requirement for sourcegraph/src-cli#398. I'll add a how-to and probably extend the docs a bit more in follow-up PRs.

@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Dec 10, 2020

Notifying subscribers in CODENOTIFY files for diff 4b17a4a...7cb46b7.

Notify File(s)
@LawnGnome doc/campaigns/references/campaign_spec_yaml_reference.md
@christinaforney doc/campaigns/references/campaign_spec_yaml_reference.md

@mrnugget mrnugget requested a review from a team December 10, 2020 14:24
Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
batch-changes Issues related to Batch Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants