Fix killing of unresponsive containers by adding init process #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `--init` flag to the `docker run` command so that the entrypoint process (`bash` in our case) is started by a init process. That fixes the behaviour of the interrupt signal simply having no effect. From what I could gather that's because PID 1 (which is the `--entrypoint` in a Docker container) is protected and cannot be killed. But `--init` is given the PID1 is an init process, which forwards the signal to our entrypoint and kills it, exiting afterwards. Resources: - https://stackoverflow.com/questions/45718967/how-do-you-kill-a-docker-containers-default-command-without-killing-the-entire-c - https://unix.stackexchange.com/questions/457649/unable-to-kill-process-with-pid-1-in-docker-container - https://stackoverflow.com/questions/31538314/stopping-docker-container-from-inside
eseliger
approved these changes
Nov 5, 2020
|
This is a campaign spec to reproduce the issue: name: sleep
description: sleep
on:
- repositoriesMatchingQuery: repo:automation-testing count:1
steps:
- run: sleep 40
container: alpine:3
changesetTemplate:
title: SLEEP
body: SLEEP
branch: campaign/sleep
commit:
message: Sleep
published: falseThis couldn't be killed before with Ctrl-C, now it does. |
40 tasks
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This adds the `--init` flag to the `docker run` command so that the entrypoint process (`bash` in our case) is started by a init process. That fixes the behaviour of the interrupt signal simply having no effect. From what I could gather that's because PID 1 (which is the `--entrypoint` in a Docker container) is protected and cannot be killed. But `--init` is given the PID1 is an init process, which forwards the signal to our entrypoint and kills it, exiting afterwards. Resources: - https://stackoverflow.com/questions/45718967/how-do-you-kill-a-docker-containers-default-command-without-killing-the-entire-c - https://unix.stackexchange.com/questions/457649/unable-to-kill-process-with-pid-1-in-docker-container - https://stackoverflow.com/questions/31538314/stopping-docker-container-from-inside
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/sourcegraph/sourcegraph/issues/15314
This adds the
--initflag to thedocker runcommand so that theentrypoint process (
bashin our case) is started by a init process.That fixes the behaviour of the interrupt signal simply having no
effect.
From what I could gather that's because PID 1 (which is the
--entrypointin a Docker container) is protected and cannot be killed.But
--initis given the PID1 is an init process, which forwards thesignal to our entrypoint and kills it, exiting afterwards.
Resources: