Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Ctrl-c in src campaign preview|apply doesn't kill unresponsive containers #15314

Closed
mrnugget opened this issue Nov 3, 2020 · 0 comments · Fixed by sourcegraph/src-cli#369
Closed

Ctrl-c in src campaign preview|apply doesn't kill unresponsive containers #15314

mrnugget opened this issue Nov 3, 2020 · 0 comments · Fixed by sourcegraph/src-cli#369
Assignees
@mrnugget
Labels
batch-changes Issues related to Batch Changes bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. estimate/1d src-cli
Milestone
Campaigns Sprint 4

Comments

@mrnugget
Copy link
Contributor

mrnugget commented Nov 3, 2020

Not sure how to reproduce this reliably, but it's something I've run into a lot:

  • Containers/steps take a long time to run
  • Hit Ctrl-C
  • Nothing happens
  • Hammer Ctrl-C
  • Nothing happens
  • do a docker ps and docker kill <cid> in a separate terminal
@mrnugget mrnugget added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. estimate/1d src-cli batch-changes Issues related to Batch Changes labels Nov 3, 2020
@mrnugget mrnugget added this to the Campaigns Sprint 4 milestone Nov 3, 2020
@mrnugget mrnugget self-assigned this Nov 3, 2020
@sourcegraph-bot sourcegraph-bot mentioned this issue Nov 3, 2020
Closed
40 tasks
@mrnugget mrnugget mentioned this issue Nov 5, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrnugget mrnugget

Labels
batch-changes Issues related to Batch Changes bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. estimate/1d src-cli
Projects
None yet
Milestone
Campaigns Sprint 4
Development

Successfully merging a pull request may close this issue.

Fix killing of unresponsive containers by adding init process sourcegraph/src-cli
1 participant
@mrnugget