Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

remove Extensions navbar item #17389

Merged
merged 2 commits into from
Jan 19, 2021
Merged

remove Extensions navbar item #17389

merged 2 commits into from
Jan 19, 2021

Conversation

5h1rU
Copy link
Contributor

@5h1rU 5h1rU commented Jan 18, 2021

fix #16567

  • Remove the menu option from the navigation bar
  • Remove the UI component from the codebase
  • Update snapshots

@5h1rU 5h1rU requested a review from felixfbecker January 18, 2021 21:22
Copy link
Contributor

@felixfbecker felixfbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Any reason this PR is only a draft? Are there still any changes you want to make before getting review or merging?

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #17389 (79d9980) into main (65295c6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #17389      +/-   ##
==========================================
- Coverage   52.14%   52.14%   -0.01%     
==========================================
  Files        1710     1709       -1     
  Lines       85379    85375       -4     
  Branches     7531     7525       -6     
==========================================
- Hits        44522    44516       -6     
- Misses      36949    36950       +1     
- Partials     3908     3909       +1     
Flag Coverage Δ
go 51.22% <ø> (-0.01%) ⬇️
integration 30.56% <ø> (-0.05%) ⬇️
storybook 30.15% <ø> (-0.02%) ⬇️
typescript 54.36% <ø> (-0.01%) ⬇️
unit 34.84% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
client/web/src/nav/NavLinks.tsx 88.23% <ø> (-0.66%) ⬇️
.../internal/codeintel/resolvers/graphql/locations.go 83.50% <0.00%> (-2.07%) ⬇️

@5h1rU 5h1rU marked this pull request as ready for review January 19, 2021 17:08
Copy link
Contributor

@AlicjaSuska AlicjaSuska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@5h1rU 5h1rU merged commit 01db917 into main Jan 19, 2021
@5h1rU 5h1rU deleted the remove-extensions-link branch January 19, 2021 17:40
@felixfbecker felixfbecker modified the milestones: 3.23, 3.24 Jan 19, 2021
@felixfbecker
Copy link
Contributor

@5h1rU Awesome! This fix needs to be cherry-picked from main into the 3.24 release branch (which is being released tomorrow). You can find the here: https://about.sourcegraph.com/handbook/engineering/releases#cherry-picking-a-fix-onto-release-branch
and get help from @sourcegraph/distribution if needed 🙂

davejrt pushed a commit that referenced this pull request Jan 19, 2021
* remove Extensions navbar item
* fix e2e test
@5h1rU
Copy link
Contributor Author

5h1rU commented Jan 19, 2021

@davejrt is the release captain. He is taking care of this commit. https://github.com/sourcegraph/sourcegraph/commit/01db917471cb8c8dce0f637a9c494c96fed351fc

Anything you need, please ping me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse navbar items to hamburger menu on small screen sizes
4 participants