-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Any reason this PR is only a draft? Are there still any changes you want to make before getting review or merging?
Codecov Report
@@ Coverage Diff @@
## main #17389 +/- ##
==========================================
- Coverage 52.14% 52.14% -0.01%
==========================================
Files 1710 1709 -1
Lines 85379 85375 -4
Branches 7531 7525 -6
==========================================
- Hits 44522 44516 -6
- Misses 36949 36950 +1
- Partials 3908 3909 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@5h1rU Awesome! This fix needs to be cherry-picked from |
* remove Extensions navbar item * fix e2e test
@davejrt is the release captain. He is taking care of this commit. https://github.com/sourcegraph/sourcegraph/commit/01db917471cb8c8dce0f637a9c494c96fed351fc Anything you need, please ping me! |
fix #16567