remove Extensions navbar item (#17389)

* remove Extensions navbar item * fix e2e test
sourcegraph · Jan 19, 2021 · 009acb0 · 009acb0
1 parent 386be18
commit 009acb0
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 326 deletions.
diff --git a/client/web/src/extensions/ExtensionsNavItem.tsx b/client/web/src/extensions/ExtensionsNavItem.tsx
diff --git a/client/web/src/integration/search.test.ts b/client/web/src/integration/search.test.ts
@@ -217,8 +217,8 @@ describe('Search', () => {
             await driver.page.waitForSelector('#monaco-query-input')
             expect(await getSearchFieldValue(driver)).toStrictEqual('foo')
             // Field value is cleared when navigating to a non search-related page
-            await driver.page.waitForSelector('[data-testid="extensions"]')
-            await driver.page.click('[data-testid="extensions"]')
+            await driver.page.waitForSelector('[data-testid="campaigns"]')
+            await driver.page.click('[data-testid="campaigns"]')
             expect(await getSearchFieldValue(driver)).toStrictEqual('')
             // Field value is restored when the back button is pressed
             await driver.page.goBack()

diff --git a/client/web/src/nav/NavLinks.tsx b/client/web/src/nav/NavLinks.tsx
@@ -25,8 +25,6 @@ import { InsightsNavItem } from '../insights/InsightsNavLink'
 import { CodeMonitoringNavItem } from '../enterprise/code-monitoring/CodeMonitoringNavItem'
 import { AuthenticatedUser } from '../auth'
 import { TelemetryProps } from '../../../shared/src/telemetry/telemetryService'
-import { ExtensionsNavItem } from '../extensions/ExtensionsNavItem'
-
 interface Props
     extends SettingsCascadeProps<Settings>,
         KeyboardShortcutsProps,
@@ -84,11 +82,6 @@ export class NavLinks extends React.PureComponent<Props> {
                             <CodeMonitoringNavItem />
                         </li>
                     )}
-                {!this.props.minimalNavLinks && (
-                    <li className="nav-item">
-                        <ExtensionsNavItem />
-                    </li>
-                )}
                 {!this.props.minimalNavLinks && this.props.showCampaigns && (
                     <li className="nav-item">
                         <CampaignsNavItem />