-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with ToCandlestickInterval() method #86
Comments
Hmmmm, not sure if it affects the subscriptions. I remember the #82 issue related to the subscription and |
@sguryev, you are correct. The |
What about my assumption about affected logic? |
The #82 issue was just the missing "6h" case. Here, the |
I'm collecting the candles using WebSocket to the custom store. I'm concerned about the data messing which this bug can lead to. My assumption that |
Before 0.2.0-beta3, using If subscribing or polling with If using the With 0.2.0-beta3, anyone previously using uppercase strings with |
Hi @sonvister ,
I worked around the
ToCandlestickInterval
extension and have noticed this line:Binance/src/Binance/Extensions/StringExtensions.cs
Line 59 in a7277db
I didn't test but I'm 99% sure that after making
s.Trim().ToLower()
you will not me able getcase "1M"
and the main problem - it will go to thecase "1m"
. What do you think?The text was updated successfully, but these errors were encountered: