Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToCandlestickInterval: interval not supported: 6h #82

Closed
sguryev opened this issue Mar 27, 2018 · 2 comments
Closed

ToCandlestickInterval: interval not supported: 6h #82

sguryev opened this issue Mar 27, 2018 · 2 comments
Assignees
@sonvister
Labels
bug

Comments

@sguryev
Copy link

sguryev commented Mar 27, 2018 •
edited
Loading

CandlestickInterval.Hours_6 can be converted to string:

Binance/src/Binance/Extensions/CandlestickIntervalExtensions.cs

Line 25 in da2967a

case CandlestickInterval.Hours_6: return "6h";

But it doesn't support the opposite conversion:

Binance/src/Binance/Extensions/StringExtensions.cs

Line 41 in da2967a

switch (s.Trim().ToLower())

Result - there is no way to subscribe for 6h interval.
Is it by design?
@sonvister sonvister added the bug label Mar 27, 2018
@sonvister sonvister self-assigned this Mar 27, 2018
@sonvister
Copy link
Owner

@sguryev, thanks for mentioning.

@sguryev
Copy link
Author

sguryev commented Mar 27, 2018 •
edited
Loading

@sonvister do you want me to prepare the PR? Ooops. it looks like I'm late. Sorry

@sguryev sguryev mentioned this issue Apr 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonvister sonvister

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sguryev @sonvister