[fast reboot] set a fast-reboot DB flag #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This flag is currently no functional impact with just this change. - This flag is intended to coordinate fast-reboot shutdown path. - This flag enables moving fast-reboot per service knowledge to service scripts. which unblocks moving warm-reboot per service knowledge to service scripts. - This flag is consistent with the bootup flag we setting on the boot up path. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
pavel-shirshov
approved these changes
Apr 23, 2020
|
retest this please |
abdosi
pushed a commit
that referenced
this pull request
Apr 27, 2020
- This flag is currently no functional impact with just this change. - This flag is intended to coordinate fast-reboot shutdown path. - This flag enables moving fast-reboot per service knowledge to service scripts. which unblocks moving warm-reboot per service knowledge to service scripts. - This flag is consistent with the bootup flag we setting on the boot up path. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
| { | ||
| common_clear | ||
|
|
||
| redis-cli -n 6 DEL "FAST_REBOOT|system" &>/dev/null || /bin/true |
There was a problem hiding this comment.
should use sonic-db-cli
There was a problem hiding this comment.
@yxieca can we change this to sonic-db-cli ?
| @@ -308,6 +315,7 @@ case "$REBOOT_TYPE" in | |||
| "fast-reboot") | |||
| BOOT_TYPE_ARG=$REBOOT_TYPE | |||
| trap clear_fast_boot EXIT HUP INT QUIT TERM KILL ABRT ALRM | |||
| redis-cli -n 6 SET "FAST_REBOOT|system" "1" "EX" "180" &>/dev/null | |||
There was a problem hiding this comment.
the same , can we change this to sonic-db-cli ? @yxieca
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
- This flag is currently no functional impact with just this change. - This flag is intended to coordinate fast-reboot shutdown path. - This flag enables moving fast-reboot per service knowledge to service scripts. which unblocks moving warm-reboot per service knowledge to service scripts. - This flag is consistent with the bootup flag we setting on the boot up path. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[Vxlan] : adding show vnet/vxlan cmds (sonic-net#880) [show][bgp] Use only 'show ip bgp' as the base and use bgp_frr_v4 file for FRR routing stack (sonic-net#884) [fast reboot] set a fast-reboot DB flag (sonic-net#887) [show] Add 'ip/ipv6 bgp network' commands (sonic-net#888)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
which unblocks moving warm-reboot per service knowledge to service scripts.
Signed-off-by: Ying Xie ying.xie@microsoft.com
- How to verify it
Did a quick fast-reboot test with the change.