-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vxlan] : adding show vnet/vxlan cmds #880
Conversation
Just a reminder to update command reference as well - https://github.com/Azure/sonic-utilities/blob/master/doc/Command-Reference.md |
retest this please |
1 similar comment
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - Few minor comments!
show/main.py
Outdated
config_db = ConfigDBConnector() | ||
config_db.connect() | ||
|
||
header = ['<vnet_name>', 'neighbor', 'interfaces'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also provide themac address
if its available in the attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added.
admin@ASW-7005:~$ show vnet neighbors
Vnet_2000 neighbor mac_address interfaces
----------- ----------- ------------- ------------
11.11.11.11 Ethernet1
Vnet_3000 neighbor mac_address interfaces
----------- ----------- ----------------- ------------
20.20.20.20 aa:bb:cc:dd:ee:ff Vlan2000
@vxlan.command() | ||
@click.argument('vxlan_name', required=True) | ||
def name(vxlan_name): | ||
"""Show vxlan name <vxlan_name> information""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you intend to have the name
in command? Its different from the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the cmd is like : show vxlan name XXX, the description is not showing <>, correct it now.
updated |
* [Vxlan] : adding show vnet/vxlan cmds
* [Vxlan] : adding show vnet/vxlan cmds
[Vxlan] : adding show vnet/vxlan cmds (sonic-net#880) [show][bgp] Use only 'show ip bgp' as the base and use bgp_frr_v4 file for FRR routing stack (sonic-net#884) [fast reboot] set a fast-reboot DB flag (sonic-net#887) [show] Add 'ip/ipv6 bgp network' commands (sonic-net#888)
add some basic show cmds:
show vnet brief
show vnet name <vnetname>
show vnet interfaces
show vnet neighbors
show vnet routes all
show vnet routes tunnel
show vxlan tunnel
show vxlan name <vxlanname>
some example as below:
Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com