[DPB]Fix return code in case of failure #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bingwang-ms Can you please review this? This is similar to #3357 |
bingwang-ms
approved these changes
Jul 1, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Jul 1, 2024
* [DPB]Fix return code in case of failure * Updating UT
|
Cherry-pick PR to 202405: #3392 |
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Jul 1, 2024
* [DPB]Fix return code in case of failure * Updating UT
|
Cherry-pick PR to 202311: #3393 |
mssonicbld
pushed a commit
that referenced
this pull request
Jul 1, 2024
* [DPB]Fix return code in case of failure * Updating UT
|
@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! |
6 similar comments
|
@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! |
|
@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! |
|
@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! |
|
@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! |
|
@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! |
|
@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! |
mssonicbld
pushed a commit
that referenced
this pull request
Jul 12, 2024
* [DPB]Fix return code in case of failure * Updating UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix return code when DPB command fails. Return of 0 indicates success which might be a problem to detect failures using automation
How I did it
Updated return code to 1
How to verify it
Basic manual testing
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)