Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPB]Fixing return code of breakout command on failure #3357

Merged
merged 1 commit into from
Jun 10, 2024
Merged

[DPB]Fixing return code of breakout command on failure #3357

merged 1 commit into from
Jun 10, 2024

Conversation

dgsudharsan
Copy link
Collaborator

What I did

Changing the return code of DPB command to 1 on failure when dependencies exit.

How I did it

Updating the exit code

How to verify it

Modified UT to verify

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@prgeor
Copy link
Contributor

prgeor commented Jun 10, 2024

@dgsudharsan what is the impact without this fix?

@dgsudharsan
Copy link
Collaborator Author

@dgsudharsan what is the impact without this fix?

Our internal tests assume that command pass based on the return code while it has actually failed. Same applies to any automation framework. If the command fails it should return non zero return code

@bingwang-ms bingwang-ms merged commit c2370f8 into sonic-net:master Jun 10, 2024
7 checks passed
@mssonicbld mssonicbld mentioned this pull request Jun 10, 2024
Closed
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Jun 10, 2024
@dgsudharsan @mssonicbld
[DPB]Fixing return code of breakout command on failure (sonic-net#3357)
a4b00e5
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #3361

@dgsudharsan
Copy link
Collaborator Author

@yxieca Can you please help to cherry-pick for 202311?

mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Jun 11, 2024
@dgsudharsan @mssonicbld
[DPB]Fixing return code of breakout command on failure (sonic-net#3357)
59ca66f
@mssonicbld mssonicbld mentioned this pull request Jun 11, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #3363

mssonicbld pushed a commit that referenced this pull request Jun 11, 2024
@dgsudharsan @mssonicbld
[DPB]Fixing return code of breakout command on failure (#3357)
68f89d6
@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!!
#3361

2 similar comments
@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!!
#3361

@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!!
#3361

arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this pull request Jun 16, 2024
@dgsudharsan @arfeigin
[DPB]Fixing return code of breakout command on failure (sonic-net#3357)
2d33c0b
@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!!
#3361

2 similar comments
@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!!
#3361

@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!!
#3361

@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!!
#3361

@dgsudharsan dgsudharsan mentioned this pull request Jun 29, 2024
Merged
@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#3361

4 similar comments
@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#3361

@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#3361

@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#3361

@mssonicbld
Copy link
Collaborator

@dgsudharsan cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#3361

@bingwang-ms
Copy link
Contributor

@dgsudharsan Cherry-pick to 202405 failed. Please check.

mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Aug 2, 2024
@dgsudharsan @mssonicbld
[DPB]Fixing return code of breakout command on failure (sonic-net#3357)
8e9c445
@mssonicbld mssonicbld mentioned this pull request Aug 2, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #3469

@dgsudharsan
Copy link
Collaborator Author

@dgsudharsan Cherry-pick to 202405 failed. Please check.

Hi @bingwang-ms I see PR already raised to 202405. Can you please clarify this comment?

mssonicbld pushed a commit that referenced this pull request Aug 2, 2024
@dgsudharsan @mssonicbld
[DPB]Fixing return code of breakout command on failure (#3357)
7643ac3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandrivantsiv oleksandrivantsiv oleksandrivantsiv approved these changes

@prgeor prgeor prgeor approved these changes

@bingwang-ms bingwang-ms bingwang-ms approved these changes

Assignees
No one assigned
Labels
Approved for 202311 Branch Approved for 202405 Branch Included in 202311 Branch Included in 202405 Branch Request for 202311 Branch Request for 202405 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dgsudharsan @prgeor @mssonicbld @bingwang-ms @oleksandrivantsiv @yxieca