Update swss_ready check to check per namespace swss service #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com> (cherry picked from commit 4457f05)
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
abdosi
approved these changes
Dec 21, 2021
|
@anamehra can you try this fix. |
|
/azp Azure.sonic-utilities |
|
Command 'Azure.sonic-utilities' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
/azp |
Supported commands
See additional documentation. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anamehra
approved these changes
Dec 21, 2021
@abdosi , tried on multi-asic LC and Sup, looks good: root@sonic:/home/cisco# config reload |
judyjoseph
pushed a commit
that referenced
this pull request
Jan 9, 2022
What I did fixes sonic-net/sonic-buildimage#9411 on multi-asic platform, config reload CLI was not working without -f option. This was because swss_ready function was checking status of swss.service and multi-asic platform will not have swss.service, it will have per-namespace swss service. How I did it Fix swss_ready function to check all swss services status running on the platform.
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
SuvarnaMeenakshi
added a commit
to SuvarnaMeenakshi/sonic-utilities
that referenced
this pull request
Feb 8, 2023
…t#1974) What I did fixes sonic-net/sonic-buildimage#9411 on multi-asic platform, config reload CLI was not working without -f option. This was because swss_ready function was checking status of swss.service and multi-asic platform will not have swss.service, it will have per-namespace swss service. How I did it Fix swss_ready function to check all swss services status running on the platform. (cherry picked from commit bb56fc2)
|
Because 202012 not run on multi-asic device, add "Rejected for 202012 branch" label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes sonic-net/sonic-buildimage#9411
on multi-asic platform, config reload CLI was not working without -f option.
This was because swss_ready function was checking status of swss.service and multi-asic platform will not have swss.service, it will have per-namespace swss service.
How I did it
Fix swss_ready function to check all swss services status running on the platform.
How to verify it
On multi-asic platform, before Fix:
admin@vlab-08:~$ sudo config reload -y
SwSS container is not ready. Retry later or use -f to avoid system checks
After fix, on multi-asic platform, execute config load_minigraph to reload all services, immediately after that execute config reload. This should print swss not ready message.
Once swss services are up, execute config reload again and this time it should run without -f option.
Verified that there is no change on single asic VS:
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)