Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config reload reports SwSS container not running for multi-asic #9411

Closed
anamehra opened this issue Nov 30, 2021 · 2 comments · Fixed by sonic-net/sonic-utilities#1974
Closed
Assignees

Comments

@anamehra
Copy link
Contributor

Description

On a multi-asic system, config reload CLI does not work wihtout -f option.
root:/home/admin# config reload
SwSS container is not ready. Retry later or use -f to avoid system checks

The issue is that config/main.py checks for swss.service status even for multi-asic system. On a multi-asic system, there is no swss.service but multi-instance versions like swss@0.service etc.

_swss_ready should be fixed to handle the multi-asic scenarios.

Steps to reproduce the issue:

  1. Boot multi asic system
  2. check docker ps to check all expected dockers running
  3. config reload

Describe the results you received:

SwSS container is not ready. Retry later or use -f to avoid system checks

Describe the results you expected:

config reload should work without -f option

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@anamehra
Copy link
Contributor Author

@abdosi

@abdosi
Copy link
Contributor

abdosi commented Dec 10, 2021

@SuvarnaMeenakshi working on this.

cc @rlhui

abdosi pushed a commit to sonic-net/sonic-utilities that referenced this issue Dec 22, 2021
What I did
fixes sonic-net/sonic-buildimage#9411
on multi-asic platform, config reload CLI was not working without -f option.
This was because swss_ready function was checking status of swss.service and multi-asic platform will not have swss.service, it will have per-namespace swss service.

How I did it
Fix swss_ready function to check all swss services status running on the platform.
judyjoseph pushed a commit to sonic-net/sonic-utilities that referenced this issue Jan 9, 2022
What I did
fixes sonic-net/sonic-buildimage#9411
on multi-asic platform, config reload CLI was not working without -f option.
This was because swss_ready function was checking status of swss.service and multi-asic platform will not have swss.service, it will have per-namespace swss service.

How I did it
Fix swss_ready function to check all swss services status running on the platform.
SuvarnaMeenakshi added a commit to SuvarnaMeenakshi/sonic-utilities that referenced this issue Feb 8, 2023
…t#1974)

What I did
fixes sonic-net/sonic-buildimage#9411
on multi-asic platform, config reload CLI was not working without -f option.
This was because swss_ready function was checking status of swss.service and multi-asic platform will not have swss.service, it will have per-namespace swss service.

How I did it
Fix swss_ready function to check all swss services status running on the platform.

(cherry picked from commit bb56fc2)
malletvapid23 added a commit to malletvapid23/Sonic-Utility that referenced this issue Aug 3, 2023
What I did
fixes sonic-net/sonic-buildimage#9411
on multi-asic platform, config reload CLI was not working without -f option.
This was because swss_ready function was checking status of swss.service and multi-asic platform will not have swss.service, it will have per-namespace swss service.

How I did it
Fix swss_ready function to check all swss services status running on the platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants