-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[202211][ppi]: General code cleanup: remove unused methods (#2867) #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marian-pritsak
approved these changes
Aug 1, 2023
@StormLiangMS can you please help to merge? |
60dfd37
to
1f7398f
Compare
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
1f7398f
to
1629754
Compare
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@StormLiangMS can you please help to merge? |
liat-grozovik
approved these changes
Aug 28, 2023
@StormLiangMS just a kind reminder |
1 similar comment
@StormLiangMS just a kind reminder |
1629754
to
f1d0344
Compare
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
f1d0344
to
e53bd85
Compare
@StormLiangMS just a kind reminder |
1 similar comment
@StormLiangMS just a kind reminder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
DEPENDS:
HLD: sonic-net/SONiC#1084
What I did
Why I did it
How I verified it
Details if related
master
: [ppi]: General code cleanup: remove unused methods #2867