Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202211][ppi]: General code cleanup: remove unused methods (#2867) #2868

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Jul 27, 2023

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

DEPENDS:

  1. [202211][ppi]: Implement port bulk comparison logic (#2564)  #2821

HLD: sonic-net/SONiC#1084

What I did

  • Removed unused code

Why I did it

  • To complete code cleanup

How I verified it

  • UT tests
  • VS tests

Details if related

@nazariig
Copy link
Collaborator Author

@StormLiangMS can you please help to merge?

@nazariig nazariig force-pushed the 202211-ppi-cleanup branch from 60dfd37 to 1f7398f Compare August 15, 2023 09:01
@nazariig
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig nazariig force-pushed the 202211-ppi-cleanup branch from 1f7398f to 1629754 Compare August 17, 2023 12:32
@nazariig
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Collaborator Author

@StormLiangMS can you please help to merge?

@liat-grozovik liat-grozovik changed the title [202211][ppi]: General code cleanup: remove unused methods [202211][ppi]: General code cleanup: remove unused methods (#2867) Aug 28, 2023
@nazariig
Copy link
Collaborator Author

@StormLiangMS just a kind reminder

1 similar comment
@nazariig
Copy link
Collaborator Author

@StormLiangMS just a kind reminder

@nazariig nazariig force-pushed the 202211-ppi-cleanup branch from 1629754 to f1d0344 Compare August 30, 2023 11:28
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig nazariig force-pushed the 202211-ppi-cleanup branch from f1d0344 to e53bd85 Compare August 31, 2023 15:01
@nazariig nazariig requested a review from yxieca September 3, 2023 13:05
@nazariig
Copy link
Collaborator Author

@StormLiangMS just a kind reminder

1 similar comment
@nazariig
Copy link
Collaborator Author

@StormLiangMS just a kind reminder

@nazariig nazariig requested a review from lguohan September 23, 2023 22:50
@StormLiangMS StormLiangMS merged commit 8d76a4e into sonic-net:202211 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants