Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ppi]: General code cleanup: remove unused methods #2867

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Jul 27, 2023

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

DEPENDS:

  1. [ppi]: Implement port bulk comparison logic #2564

HLD: sonic-net/SONiC#1084

What I did

  • Removed unused code

Why I did it

  • To complete code cleanup

How I verified it

  • UT tests
  • VS tests

Details if related

  • N/A

@nazariig
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Collaborator Author

nazariig commented Aug 7, 2023

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig nazariig force-pushed the master-ppi-cleanup branch from e05cc2d to c1951bf Compare August 7, 2023 22:28
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig nazariig force-pushed the master-ppi-cleanup branch from c1951bf to cfbbd30 Compare August 9, 2023 15:27
@nazariig
Copy link
Collaborator Author

nazariig commented Aug 9, 2023

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Collaborator Author

nazariig commented Aug 9, 2023

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik merged commit 7251623 into sonic-net:master Aug 10, 2023
keboliu added a commit to keboliu/sonic-swss that referenced this pull request Aug 31, 2023
StormLiangMS pushed a commit that referenced this pull request Sep 25, 2023
DEPENDS:

[202211][ppi]: Implement port bulk comparison logic (#2564)  #2821
HLD: sonic-net/SONiC#1084

What I did

Removed unused code
Why I did it

To complete code cleanup
How I verified it

UT tests
VS tests
Details if related

Backport from master: [ppi]: General code cleanup: remove unused methods #2867
dgsudharsan pushed a commit to dgsudharsan/sonic-swss that referenced this pull request Oct 4, 2023
- What I did
Removed unused code

- Why I did it
To complete code cleanup

- How I verified it
UT tests
VS tests

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants