made test_decap to check both DSCP/TTL modes for SONiC 202012 and later #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
i like the idea here. however, my concern is that maybe some platform does not support uniform/uniform or pipe/pipe combination. if you look at the original code, for 202012+, it is testing uniform/pipe combination. i suggest to keep this combination. maybe for your platform, you can test uniform/uniform and pipe/pipe combination. |
|
@lguohan I've made changes, please review. I decided to introduce ttl/dscp CLI flags to have an ability to communicate uniform mode support to the test, so test parameters set is built based on that. Flag defaults are set to the combination you requested - dscp=uniform, ttl=pipe |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Aug 26, 2021
prsunny
reviewed
Sep 15, 2021
|
|
||
| # The hostvars dict has definitions defined in ansible/group_vars/sonic/variables | ||
| hostvars = duthosts[0].host.options["variable_manager"]._hostvars[duthosts[0].hostname] | ||
| sonic_hwsku = duthosts[0].sonichost.facts["hwsku"] | ||
| mellanox_hwskus = hostvars.get("mellanox_hwskus", []) | ||
|
|
||
| if sonic_hwsku in mellanox_hwskus: | ||
| dscp_mode = "uniform" |
There was a problem hiding this comment.
This breaks mellanox skus. MLNX supports "uniform" on all image versions
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…er (sonic-net#3887) Description of PR Summary: made test_decap to check both DSCP/TTL modes for SONiC 202012 and later Fix sonic-net#3355 uniform mode for ttl and dscp became available for IPinIP tunnel configuration starting from 202012 so made the test to run with ttl/dscp uniform mode for OS ver 202012 and later. Approach What is the motivation for this PR? Adapt the test to covered feature improvements How did you do it? Parametrized the test to run with uniform ttl/dscp mode if supported for a given OS ver How did you verify/test it? py.test --inventory=../ansible/lab,../ansible/veos --testbed_file=../ansible/testbed.csv --module-path=../ansible/library -v -rA --topology=any decap/test_decap.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: made test_decap to check both DSCP/TTL modes for SONiC 202012 and later
Fix #3355
Type of change
Back port request
Approach
What is the motivation for this PR?
Adapt the test to covered feature improvements
How did you do it?
Parametrized the test to run with uniform ttl/dscp mode if supported for a given OS ver
How did you verify/test it?
py.test --inventory=../ansible/lab,../ansible/veos --testbed_file=../ansible/testbed.csv --module-path=../ansible/library -v -rA --topology=any decap/test_decap.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation