Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPinIP decap] Test to verify DSCP pipe mode #3355

Closed
prsunny opened this issue Apr 17, 2021 · 2 comments · Fixed by #3887
Closed

[IPinIP decap] Test to verify DSCP pipe mode #3355

prsunny opened this issue Apr 17, 2021 · 2 comments · Fixed by #3887

Comments

@prsunny
Copy link
Contributor

prsunny commented Apr 17, 2021

Description

Require test to verify DSCP pipe mode for Broadcom platforms (202012 version and above). With the PR to change dscp mode from pipe to uniform, need a test enhancement to cover pipe mode.

This enhancement can be done over the current test_decap.py script. However, this may require a removal of existing IP TUNNEL config and re-installation. Currently there is a limitation with Tunnel delete tracked as part of CSP CS00012182145

Steps to reproduce the issue:

  1. Run test_decap test.

Describe the results you received:

Describe the results you expected:
Test should cover both dscp uniform and pipe models.

Additional information you deem important:

**Output of `show version`:**

```
(paste your output here)
```

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```
@antonptashnik
Copy link
Contributor

hi @prsunny . Taking this issue into account I understand that DSCP uniform mode is an additional mode appeared in SONiC 202012, so versions before 202012 support only DSCP pipe and later versions support both DSCP pipe and uniform. Correct ?

@prsunny
Copy link
Contributor Author

prsunny commented Jul 23, 2021

hi @prsunny . Taking this issue into account I understand that DSCP uniform mode is an additional mode appeared in SONiC 202012, so versions before 202012 support only DSCP pipe and later versions support both DSCP pipe and uniform. Correct ?

thats right

yxieca pushed a commit that referenced this issue Sep 2, 2021
…er (#3887)

Description of PR
Summary: made test_decap to check both DSCP/TTL modes for SONiC 202012 and later
Fix #3355

uniform mode for ttl and dscp became available for IPinIP tunnel configuration starting from 202012 so made the test to run with ttl/dscp uniform mode for OS ver 202012 and later.

Approach
What is the motivation for this PR?
Adapt the test to covered feature improvements

How did you do it?
Parametrized the test to run with uniform ttl/dscp mode if supported for a given OS ver

How did you verify/test it?
py.test --inventory=../ansible/lab,../ansible/veos --testbed_file=../ansible/testbed.csv --module-path=../ansible/library -v -rA --topology=any decap/test_decap.py
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this issue Sep 28, 2021
…er (sonic-net#3887)

Description of PR
Summary: made test_decap to check both DSCP/TTL modes for SONiC 202012 and later
Fix sonic-net#3355

uniform mode for ttl and dscp became available for IPinIP tunnel configuration starting from 202012 so made the test to run with ttl/dscp uniform mode for OS ver 202012 and later.

Approach
What is the motivation for this PR?
Adapt the test to covered feature improvements

How did you do it?
Parametrized the test to run with uniform ttl/dscp mode if supported for a given OS ver

How did you verify/test it?
py.test --inventory=../ansible/lab,../ansible/veos --testbed_file=../ansible/testbed.csv --module-path=../ansible/library -v -rA --topology=any decap/test_decap.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants