Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arista] Fix dockerd issue on Arista platforms #7376

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

Staphylo
Copy link
Collaborator

@Staphylo Staphylo commented Apr 20, 2021

Why I did it

Recent systemd upgrade from #7228 requires an extra cmdline parameter for dockerd to start properly.
Updating boot0 was missed as part of the systemd upgrade change.

How I did it

Just added the missing cmdline parameter in files/Aboot/boot0.j2
This change fixes #7372

How to verify it

Boot the image and dockerd should start normally.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

I'm not sure if systemd will be upgraded in 202012.
If it is, this change will have to be cherry-picked.

Description for the changelog

Fix dockerd issue on Arista platforms due to missing cmdline parameter

Recent systemd upgrade from sonic-net#7228 requires an extra cmdline parameter
for dockerd to start properly.
Updating boot0 was missed as part of the systemd upgrade change.
This change fixes sonic-net#7372

Signed-off-by: Samuel Angebault <staphylo@arista.com>
@Staphylo Staphylo requested a review from lguohan as a code owner April 20, 2021 00:49
@Staphylo
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 7376 in repo Azure/sonic-buildimage

@yxieca yxieca merged commit 96690fa into sonic-net:master Apr 20, 2021
lguohan pushed a commit that referenced this pull request May 2, 2021
Why I did it
Recent systemd upgrade from #7228 requires an extra cmdline parameter for dockerd to start properly.
Updating boot0 was missed as part of the systemd upgrade change.

How I did it
Just added the missing cmdline parameter in files/Aboot/boot0.j2
This change fixes #7372

How to verify it
Boot the image and dockerd should start normally.
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
Why I did it
Recent systemd upgrade from sonic-net#7228 requires an extra cmdline parameter for dockerd to start properly.
Updating boot0 was missed as part of the systemd upgrade change.

How I did it
Just added the missing cmdline parameter in files/Aboot/boot0.j2
This change fixes sonic-net#7372

How to verify it
Boot the image and dockerd should start normally.
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Why I did it
Recent systemd upgrade from sonic-net#7228 requires an extra cmdline parameter for dockerd to start properly.
Updating boot0 was missed as part of the systemd upgrade change.

How I did it
Just added the missing cmdline parameter in files/Aboot/boot0.j2
This change fixes sonic-net#7372

How to verify it
Boot the image and dockerd should start normally.
@Staphylo Staphylo deleted the master-systemd-upgrade branch December 6, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker startup broken in master for aboot due to systemd upgrade
5 participants