-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[debian] install systemd version 247 from buster-backports #7228
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
is there a behavior change when upgrade to 247 for the unified_cgroup_hierarchy? why is that we do not need pass this option prior to 247? |
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@lguohan yes, there is a behaviour change in systemd v247 comparing to 241. Systemd comes now with cgroup v2 (unified hierarchy) by default. Current docker version does not work with cgroup v2 (comming in docker 20.10). To solve this without updating docker a unified_cgroup_hierarchy is set to 0 in kernel arguments. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please wait other reviewers' approval.
Fix #7180 Update systemd to v247 in order to pick the fix for "core: coldplug possible nop_job" systemd/systemd#13124 Install systemd, systemd-sysv from buster-backports. Pass "systemd.unified_cgroup_hierarchy=0" as kernel argument to force systemd to not use unified cgroup hierarchy, otherwise dockerd won't start moby/moby#16238. Also, chown $FILSYSTEM_ROOT for root, otherwise apt systemd installation complains, see similar https://unix.stackexchange.com/questions/593529/can-not-configure-systemd-inside-a-chrooted-environment Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
- Support compile sonic arm image on arm server. If arm image compiling is executed on arm server instead of using qemu mode on x86 server, compile time can be saved significantly. - Add kernel argument systemd.unified_cgroup_hierarchy=0 for upgrade systemd to version 247, according to #7228 - rename multiarch docker to sonic-slave-${distro}-march-${arch} Co-authored-by: Xianghong Gu <xgu@centecnetworks.com> Co-authored-by: Shi Lei <shil@centecnetworks.com>
Recent systemd upgrade from sonic-net#7228 requires an extra cmdline parameter for dockerd to start properly. Updating boot0 was missed as part of the systemd upgrade change. This change fixes sonic-net#7372 Signed-off-by: Samuel Angebault <staphylo@arista.com>
Why I did it Recent systemd upgrade from #7228 requires an extra cmdline parameter for dockerd to start properly. Updating boot0 was missed as part of the systemd upgrade change. How I did it Just added the missing cmdline parameter in files/Aboot/boot0.j2 This change fixes #7372 How to verify it Boot the image and dockerd should start normally.
Why I did it Recent systemd upgrade from #7228 requires an extra cmdline parameter for dockerd to start properly. Updating boot0 was missed as part of the systemd upgrade change. How I did it Just added the missing cmdline parameter in files/Aboot/boot0.j2 This change fixes #7372 How to verify it Boot the image and dockerd should start normally.
- Support compile sonic arm image on arm server. If arm image compiling is executed on arm server instead of using qemu mode on x86 server, compile time can be saved significantly. - Add kernel argument systemd.unified_cgroup_hierarchy=0 for upgrade systemd to version 247, according to #7228 - rename multiarch docker to sonic-slave-${distro}-march-${arch} Co-authored-by: Xianghong Gu <xgu@centecnetworks.com> Co-authored-by: Shi Lei <shil@centecnetworks.com>
…#7228) Fix sonic-net#7180 Update systemd to v247 in order to pick the fix for "core: coldplug possible nop_job" systemd/systemd#13124 Install systemd, systemd-sysv from buster-backports. Pass "systemd.unified_cgroup_hierarchy=0" as kernel argument to force systemd to not use unified cgroup hierarchy, otherwise dockerd won't start moby/moby#16238. Also, chown $FILSYSTEM_ROOT for root, otherwise apt systemd installation complains, see similar https://unix.stackexchange.com/questions/593529/can-not-configure-systemd-inside-a-chrooted-environment Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
- Support compile sonic arm image on arm server. If arm image compiling is executed on arm server instead of using qemu mode on x86 server, compile time can be saved significantly. - Add kernel argument systemd.unified_cgroup_hierarchy=0 for upgrade systemd to version 247, according to sonic-net#7228 - rename multiarch docker to sonic-slave-${distro}-march-${arch} Co-authored-by: Xianghong Gu <xgu@centecnetworks.com> Co-authored-by: Shi Lei <shil@centecnetworks.com>
Why I did it Recent systemd upgrade from sonic-net#7228 requires an extra cmdline parameter for dockerd to start properly. Updating boot0 was missed as part of the systemd upgrade change. How I did it Just added the missing cmdline parameter in files/Aboot/boot0.j2 This change fixes sonic-net#7372 How to verify it Boot the image and dockerd should start normally.
…#7228) Fix sonic-net#7180 Update systemd to v247 in order to pick the fix for "core: coldplug possible nop_job" systemd/systemd#13124 Install systemd, systemd-sysv from buster-backports. Pass "systemd.unified_cgroup_hierarchy=0" as kernel argument to force systemd to not use unified cgroup hierarchy, otherwise dockerd won't start moby/moby#16238. Also, chown $FILSYSTEM_ROOT for root, otherwise apt systemd installation complains, see similar https://unix.stackexchange.com/questions/593529/can-not-configure-systemd-inside-a-chrooted-environment Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
- Support compile sonic arm image on arm server. If arm image compiling is executed on arm server instead of using qemu mode on x86 server, compile time can be saved significantly. - Add kernel argument systemd.unified_cgroup_hierarchy=0 for upgrade systemd to version 247, according to sonic-net#7228 - rename multiarch docker to sonic-slave-${distro}-march-${arch} Co-authored-by: Xianghong Gu <xgu@centecnetworks.com> Co-authored-by: Shi Lei <shil@centecnetworks.com>
Why I did it Recent systemd upgrade from sonic-net#7228 requires an extra cmdline parameter for dockerd to start properly. Updating boot0 was missed as part of the systemd upgrade change. How I did it Just added the missing cmdline parameter in files/Aboot/boot0.j2 This change fixes sonic-net#7372 How to verify it Boot the image and dockerd should start normally.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
Why I did it
Update systemd to v247 in order to pick the fix for "core: coldplug possible nop_job" systemd/systemd#13124
How I did it
Install systemd, systemd-sysv from buster-backports. Pass "systemd.unified_cgroup_hierarchy=0" as kernel argument to force systemd to not use unified cgroup hierarchy, otherwise dockerd won't start moby/moby#16238.
Also, chown $FILSYSTEM_ROOT for root, otherwise apt systemd installation complains, see similar https://unix.stackexchange.com/questions/593529/can-not-configure-systemd-inside-a-chrooted-environment
How to verify it
Install on the switch, perform basic sanity tests/
Which release branch to backport (provide reason below if selected)
Description for the changelog
Update systemd to v247
A picture of a cute animal (not mandatory but encouraged)