Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201811][platform-cel]: Fix dx010 FSC error #4949

Merged
merged 5 commits into from
Sep 17, 2020

Conversation

mudsut4ke
Copy link
Contributor

@mudsut4ke mudsut4ke commented Jul 13, 2020

- Why I did it

- How I did it

  • Add GPIO init script for Fan
  • Replace fancontrol in pmon

- How to verify it

Signed-off-by: Wirut Getbamrung [wgetbumr@celestica.com]

@mudsut4ke mudsut4ke marked this pull request as ready for review July 14, 2020 10:49
@lguohan lguohan requested review from botatoes and yxieca and removed request for botatoes July 14, 2020 15:12
@yxieca
Copy link
Contributor

yxieca commented Jul 14, 2020

This change has some improvement but didn't address the issue fully:

Improvement: the fancontrol module no longer generate error:

Jul 14 18:09:45 sonic fancontrol.sh[1448]: MAXPWM=255
Jul 14 18:09:45 sonic fancontrol.sh[1448]: THYST=3
Jul 14 18:09:45 sonic fancontrol.sh[1448]: THYST=3
Jul 14 18:09:45 sonic fancontrol.sh[1448]: Settings for ASIC temperature sensor:
Jul 14 18:09:45 sonic fancontrol.sh[1448]: Settings for ASIC temperature sensor:
Jul 14 18:09:45 sonic fancontrol.sh[1448]: Depends on /sys/bus/i2c/devices/7-004a/hwmon/hwmon*/temp1_input
Jul 14 18:09:45 sonic fancontrol.sh[1448]: MAXTEMPCRIT=75
Jul 14 18:09:45 sonic fancontrol.sh[1448]: Depends on /sys/bus/i2c/devices/7-004a/hwmon/hwmon*/temp1_input
Jul 14 18:09:45 sonic fancontrol.sh[1448]: MAXTEMPCRIT=75
Jul 14 18:09:45 sonic fancontrol.sh[1448]: Settings for CPU temperature sensor:
Jul 14 18:09:45 sonic fancontrol.sh[1448]: Settings for CPU temperature sensor:
Jul 14 18:09:45 sonic fancontrol.sh[1448]: Depends on /sys/bus/i2c/devices/14-0048/hwmon/hwmon*/temp1_input
Jul 14 18:09:45 sonic fancontrol.sh[1448]: Depends on /sys/bus/i2c/devices/14-0048/hwmon/hwmon*/temp1_input
Jul 14 18:09:45 sonic fancontrol.sh[1448]: MAXTEMPCRIT=75
Jul 14 18:09:45 sonic fancontrol.sh[1448]: MAXTEMPCRIT=75
Jul 14 18:09:45 sonic fancontrol.sh[1448]: Enabling PWM on fans...
Jul 14 18:09:45 sonic fancontrol.sh[1448]: Enabling PWM on fans...
Jul 14 18:09:46 sonic fancontrol.sh[1448]: Starting automatic fan control...
Jul 14 18:09:46 sonic fancontrol.sh[1448]: Starting automatic fan control...

Issue left:
admin@str-dx010-acs-1:~$ docker exec -it pmon bash
root@str-dx010-acs-1:/# supervisorctl status
fancontrol STOPPED Not started
ledd EXITED Jul 14 06:10 PM
lm-sensors EXITED Jul 14 06:09 PM
rsyslogd RUNNING pid 12, uptime 0:02:09
start.sh EXITED Jul 14 06:10 PM
xcvrd RUNNING pid 37, uptime 0:01:44

root@str-dx010-acs-1:/# supervisorctl start fancontrol
fancontrol: ERROR (spawn error)
root@str-dx010-acs-1:/# supervisorctl status
fancontrol BACKOFF Exited too quickly (process log may have details)
ledd EXITED Jul 14 06:10 PM
lm-sensors EXITED Jul 14 06:09 PM
rsyslogd RUNNING pid 12, uptime 0:03:46
start.sh EXITED Jul 14 06:10 PM
xcvrd RUNNING pid 37, uptime 0:03:21
root@str-dx010-acs-1:/# supervisorctl status
fancontrol FATAL Exited too quickly (process log may have details)
ledd EXITED Jul 14 06:10 PM
lm-sensors EXITED Jul 14 06:09 PM
rsyslogd RUNNING pid 12, uptime 0:03:53
start.sh EXITED Jul 14 06:10 PM
xcvrd RUNNING pid 37, uptime 0:03:28

@mudsut4ke
Copy link
Contributor Author

@yxieca , I am discussing about the solution in an email

Copy link
Contributor

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't work. Fancontrol is still down in pmon docker. Please test your change before submitting for review.

@mudsut4ke
Copy link
Contributor Author

This change doesn't work. Fancontrol is still down in pmon docker. Please test your change before submitting for review.

@yxieca, this change is to fix an error of fancontrol daemon
but anyway the our fancontrol daemon is running on sonic host
so fancontrol daemon on pmon is not in use

Wirut Getbamrung added 2 commits September 14, 2020 15:16
@mudsut4ke
Copy link
Contributor Author

@yxieca , I have submitted new change to run fancontrol in pmon docker (8c36627)

Please review it again

@mudsut4ke mudsut4ke requested a review from yxieca September 15, 2020 04:37
@yxieca yxieca merged commit ec07d10 into sonic-net:201811 Sep 17, 2020
yxieca added a commit that referenced this pull request Sep 29, 2020
yxieca added a commit that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants