Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[201811][platform/cel]: Port fancontrol changes for dx010/e1031 to 201811 branch #4867

Merged
merged 7 commits into from
Jul 4, 2020
Merged

[201811][platform/cel]: Port fancontrol changes for dx010/e1031 to 201811 branch #4867

merged 7 commits into from
Jul 4, 2020

Conversation

mudsut4ke
Copy link
Contributor

@mudsut4ke mudsut4ke commented Jun 29, 2020 •
edited
Loading

- What I did

  • Update fancontrol service for Seastone-DX010/E1031 device to support hysteresis temperature threshold and difference config for each unit fan direction type (B2F/F2B) follow master branch

- How I did it

  • Add fancontrol config file fancontrol-B2F,fancontrol-F2B
  • Add fancontrol script fancontrol.sh
  • Modify fancontrol daemon to support i2c base config

- How to verify it

Signed-off-by: Wirut Getbamrung wgetbumr@celestica.com

@mudsut4ke
Copy link
Contributor Author

retest broadcom please

@yxieca yxieca requested a review from jleveque July 1, 2020 03:04
jleveque
jleveque suggested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is inconsistent alignment in a number of these files due to a combination of tabs and spaces. Please replace all tabs with four spaces throughout.

@jleveque jleveque changed the title [platform/cel]: Porting back dx010/e1031 FSC to 201811 branch [201811][platform/cel]: Port fancontrol changes for dx010/e1031 to 201811 branch Jul 1, 2020
@mudsut4ke mudsut4ke marked this pull request as ready for review July 1, 2020 07:35
@mudsut4ke
Copy link
Contributor Author

There is inconsistent alignment in a number of these files due to a combination of tabs and spaces. Please replace all tabs with four spaces throughout.

@jleveque , updated in a5d529d

@jleveque jleveque merged commit c9d86f0 into sonic-net:201811 Jul 4, 2020
@mudsut4ke mudsut4ke mentioned this pull request Jul 13, 2020
Merged
yxieca added a commit that referenced this pull request Sep 29, 2020
@yxieca
Revert "[201811][platform/cel]: Port fancontrol changes for dx010/e10…
539860f 
…31 to 201811 branch (#4867)"

This reverts commit c9d86f0.
@yxieca yxieca mentioned this pull request Sep 29, 2020
Merged
yxieca added a commit that referenced this pull request Sep 30, 2020
@yxieca
Revert "[201811][platform/cel]: Port fancontrol changes for dx010/e10…
4c80d99 
…31 to 201811 branch (#4867)" (#5496)

This reverts commit c9d86f0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
Bug 🐛 Enhancement ➕ Included in 201811 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mudsut4ke @jleveque